[PATCH v1 0/4] Added QCOM RPMH Power Domain Driver

[Casey Connolly]

Hi Aswin,

On 6/26/25 13:24, Aswin Murugan wrote:
> This patch series adds support for the Qualcomm RPMH power domain
> driver, responsible for managing power domains on Qualcomm SoCs.
> The driver is ported from the Linux kernel and adapted for
> U-Boot to enable proper power domain control on SA8775P platform.

Thanks for working on this! I'm very glad to be reducing the amount of 
DT fixups we do at runtime.

Before getting too deep into the code I have to push back on part of 
your approach here. I would ideally like to see the fixup code removed 
entirely and rpmh-pd support for most if not all platforms, I think this 
should be possible? At worst we could have some "stub" code for 
untested/broken platforms which would also let us drop the fixup code.

Something missing from your description here is an explanation of the 
motivations for this. What platform is it needed for and why? Are there 
intentions to expand this in the future? etc...

I guess this comes down to a slightly broader topic that I'm kind of 
flying blind when it comes to the work you folks are doing, it would be 
good if we could have some regular meeting off-list to discuss this 
stuff so that I can better align the work you're doing with the work 
going on at Linaro and in the community as there is a lot of overlap. 
I'll follow up about this off-list.

Thanks and kind regards,

> 
> Aswin Murugan (4):
>    power-domain: Add QCOM RPMH Power Domain Driver Support
>    soc: qcom: cmd-db: Add cmd_db_read_slave_id() & cmd_db_read_aux_data()
>      functions
>    mach-snapdragon: fixup power-domains
>    configs: qcom: Add OF_LIVE_SA8775P & QCOM_POWER_DOMAIN config
> 
>   arch/arm/mach-snapdragon/Kconfig    |   7 +
>   arch/arm/mach-snapdragon/of_fixup.c |   6 +
>   configs/qcom_defconfig              |   1 +
>   configs/qcs9100_defconfig           |   2 +
>   drivers/power/domain/Kconfig        |   8 +
>   drivers/power/domain/Makefile       |   1 +
>   drivers/power/domain/qcom-rpmhpd.c  | 271 ++++++++++++++++++++++++++++
>   drivers/soc/qcom/cmd-db.c           |  45 +++++
>   include/soc/qcom/cmd-db.h           |   2 +
>   9 files changed, 343 insertions(+)
>   create mode 100644 drivers/power/domain/qcom-rpmhpd.c
> 

-- 
Casey (she/they)