[PATCH 0/2] video: display: refactor display_read_timing to avoid code duplication

Julien Stephan jstephan at baylibre.com
Mon Jun 30 12:08:14 CEST 2025


Commit 2dcf143398ad ("dm: video: Repurpose the 'displayport' uclass to 'display'")
left the display_read_edid() function unused by mistake.

This series addresses that oversight and introduces a new useful cmd.

Patch 1:
 - Refactors display_read_timing() to use the existing
   display_read_edid() function, eliminating redundant code.
 - Marks display_read_edid() as static since it is not used outside of
   the file.

Patch 2:
 - Adds a new read_edid command, which can be very useful for debugging
   or developing new display drivers.
 - As this command uses display_read_edid(), the function is made
   non-static again.

The patches are deliberately split to allow the functional refactoring
(Patch 1) to be applied independently, even if the command addition
(Patch 2) is deemed unnecessary.

Cheers,
Julien

Signed-off-by: Julien Stephan <jstephan at baylibre.com>
---
Julien Stephan (2):
      video: display: refactor display_read_timing to avoid code duplication
      cmd: add new command to read edid

 cmd/Kconfig                    |  6 ++++++
 cmd/Makefile                   |  1 +
 cmd/read_edid.c                | 37 +++++++++++++++++++++++++++++++++++++
 drivers/video/display-uclass.c |  4 +---
 include/display.h              | 10 ++++++++++
 5 files changed, 55 insertions(+), 3 deletions(-)
---
base-commit: 17012e3068d047ad71460f039eeb0c3be63f82a0
change-id: 20250630-read_edid_cleanup-8b85e61d3763

Best regards,
-- 
Julien Stephan <jstephan at baylibre.com>



More information about the U-Boot mailing list