[PATCH 1/2] Put common r7s72100 code in board/renesas/common

[Marek Vasut]

On 6/30/25 2:38 PM, Magnus Damm wrote:

Hello Magnus,

>>> Break out SoC specific code from the GR-Peach board and put it into the
>>> board/renesas/common directory so it can be easily shared between the
>>> GR-Peach and Genmai boards.
>> I've pushed an SH Ethernet clean up patchset , defconfig split patch and
>> fixups for these two Genmai patches to [1].
>>
>> The SH ethernet clean up patchset removes all SH ethernet related config
>> options from include/configs/*h . The defconfig split patch deduplicates
>> the RZ/A1 configs/*_defconfig files. The fixup! patches implement a
>> couple of quick changes to this patchset, mainly duplicate newline
>> removal, sort of various entries, and deduplication of genmai defconfig
>> . No functional change is expected.
>>
>> Can you please test the [1] on Genmai and see if nothing got broken ? If
>> this works as expected, I will submit the SH ethernet clean up patchset
>> and the defconfig split patch.
> 
> Now I've tested the following commit and it seems to well on Genmai:
> 
> 1e87c1bfe83714e3b813e3200bb880c2a77b0ef6 (HEAD,
> origin/test-sheth-genmai) fixup! Add support for the r7s72100 Genmai
> board

Thank you for testing.

>> If you agree with the fixup! patches,
>> could you then please squash them into these two patches and submit V2 ?
>>
>> Also, please update the subject prefix on these two patches and add
>> "ARM: renesas: ..." subject tags .
>>
>> [1]
>> https://source.denx.de/u-boot/custodians/u-boot-sh/-/commits/test-sheth-genmai
> 
> Thanks for fixing up the code and yes I do agree. No problem about
> squashing the patches and submitting the result as V2. I also need to
> adjust CONFIG_TEXT_BASE to make the code execute from NOR Flash.

Can you try and enable CONFIG_POSITION_INDEPENDENT=y and set 
CONFIG_SYS_TEXT_BASE=0x0 , and try if that still works ?

That will make U-Boot into position independent executable, which can be 
loaded to any arbitrary memory address (as long as it is aligned to 4 or 
8 bytes), and started from that address. I think that should address 
this problem.

> On top of which tree would you like me to prepare V2?

I have posted series [1] and patch [2] , so u-boot/next with [1] and [2] 
applied would be ideal.

Thank you

[1] https://patchwork.ozlabs.org/project/uboot/list/?series=463012
[2] https://patchwork.ozlabs.org/project/uboot/list/?series=463013

-- 
Best regards,
Marek Vasut