[PATCH v2 02/22] congatec: Include env.h to permit reading the environment

[Tom Rini]

On Thu, May 01, 2025 at 09:04:45AM -0600, Simon Glass wrote:
> Hi Tom,
> 
> On Thu, 1 May 2025 at 08:06, Tom Rini <trini at konsulko.com> wrote:
> >
> > On Wed, Apr 30, 2025 at 07:04:27PM -0600, Simon Glass wrote:
> > > This file reads from the environment but does not include the correct
> > > header. Update it.
> > >
> > > Drop the unnecessary config.h while we are here.
> >
> > Are you sure about that? It was explicitly added in commit
> > ab61cc7d98f6 ("board: congatec: Remove <common.h> and add needed
> > includes") probably because of CFG_SYS_... usage.
> 
> Well I assumed it wouldn't build if it had it, but perhaps that is
> incorrect? I understood that CFG_ things had to be values and you
> couldn't #idef them?

The cases where in that series I added config.h were for good reason,
either failure to build or tricky size change reasons. All were
intentional. An audit-and-remove of config.h would be it's own series as
yes, there's perhaps not the need now as whatever complex chain was
unwound.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250501/9ef9f2cb/attachment.sig>