[PATCH v2 00/13] pinctrl: rockchip: fix editing const struct + constify rockchip_pin_ctrl

Quentin Schulz quentin.schulz at cherry.de
Mon May 5 16:06:15 CEST 2025


Hi Kever,

On 1/31/25 11:31 AM, Quentin Schulz wrote:
> While testing some WIP work done by Ilias Apalodimas on guaranteeing
> read-only memory areas truly are handled as read-only[1], my RK3588
> Tiger couldn't reach U-Boot CLI anymore because of the pinctrl driver
> modifying a const struct rockchip_pin_ctrl, triggering a CPU abort.
> 
> Instead of going the lazy way and unconstify it, let's fix the actual
> issue in play.
> 
> This also means we should be able to constify the private data of the
> controller device for all Rockchip devices, instead of having those only
> for RK356x, RK3588 and RV1126. With the constify done on top of Ilias
> patch series[1], my PX30 Ringneck, RK3399 Puma and RK3588 Tiger all
> reach U-Boot CLI. No further testing (like booting into Linux userspace)
> was done.
> 
> [1] https://lore.kernel.org/u-boot/20250130072100.27297-1-ilias.apalodimas@linaro.org/
> 
> Signed-off-by: Quentin Schulz <quentin.schulz at cherry.de>
> ---

Gentle ping as I don't see it in your u-boot-rockchip custodian tree 
right now? I see that you added your Reviewed-by on the v1, but please 
take the v2!

Cheers,
Quentin


More information about the U-Boot mailing list