[PATCH] test: Add setuptools to test requirements.txt

[Tom Rini]

On Mon, May 05, 2025 at 03:14:13PM -0600, Javier Tia wrote:
> Hi Tom,
> 
> On Mon, May 5, 2025, at 3:08 PM, Tom Rini wrote:
> > On Mon, May 05, 2025 at 02:50:51PM -0600, Javier Tia wrote:
> >
> >> It solves the following error:
> >> 
> >> ❯ ./test/py/test.py --bd sandbox --build
> >> +make O=/u-boot/build-sandbox -s sandbox_defconfig
> >> +make O=/u-boot/build-sandbox -s -j32
> >> Traceback (most recent call last):
> >>   File "/u-boot/build-sandbox/../scripts/dtc/pylibfdt/setup.py", line 23, in <module>
> >>     from setuptools import setup, Extension
> >> ModuleNotFoundError: No module named 'setuptools
> >> 
> >> Signed-off-by: Javier Tia <javier.tia at linaro.org>
> >> ---
> >>  test/py/requirements.txt | 1 +
> >>  1 file changed, 1 insertion(+)
> >
> > This is the wrong place. You can't build U-Boot without
> > python3-setuptools being available, so it's part of the implicit or
> > explicit dependencies in doc/build/gcc.rst. I believe for Ubuntu/etc
> > it's implicit but should likely be explicit.
> 
> What about the use case where you just want to run the U-Boot CI tests?

You still have to have built U-Boot.

> I found this problem just following the documentation at https://docs.u-boot.org/en/latest/develop/py_testing.html.
> 
> $ cd /path/to/u-boot
> $ python3 -m venv venv
> $ . ./venv/bin/activate
> $ pip install -r test/py/requirements.txt
> $ make mrproper
> $ ./test/py/test.py --bd sandbox --build

Right, and the failure comes from not being able to build U-Boot. Part
of commit 859621b47f9e ("python: Recreate test/py and tools/buildman
requirements.txt files") was to remove the parts of
test/py/requirements.txt that are not from the test/py suite, as it had
become the location for any python module required, not the test suite.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250505/4653e276/attachment.sig>