[PATCH v4 0/6] watchdog: at91sam9_wdt driver enhancement
Eugen Hristev
eugen.hristev at linaro.org
Tue May 6 13:20:49 CEST 2025
Hello Zixun,
On 4/28/25 12:16, Zixun LI wrote:
> This patch series includes some code refactor and adds new device support
> for at91sam9_wdt driver.
>
> Instead of add a new driver like Linux kernel, at91sam9_wdt driver is
> extended as new watchdog variant is similar to existing one, especially
> for the function subset used by u-boot.
>
> 1. Remove typedef struct and rename variables for readability.
>
> 2. Add SAMA5D4 compatible, it has the same watchdog as SAM9260 except a
> new lockout feature is added. Currently this feature is unimplemented.
>
> 3. SAM9X60, SAM9X7 and SAMA7 series have a new watchdog variant, some
> bitfields bof MR register shifted their position, a new register is added
> for timer value.
>
> 4. Add DT node to SAM9X60-Currently board
>
> It has been tested on SAM9X60-Currently board:
> - Start & stop
> - Set timeout from DT node
> - Reset kick in with a while(1) loop
>
> Changes in v4:
> - Move 'timeout-sec' to at91-sam9x60-curiosity-u-boot.dtsi
>
> Changes in v3:
> - Merge relevant commits into one
> - Match DT node with Linux
> - Move default timeout from board dts to sam9x60.dtsi
>
> Changes in v2:
> - Fix SPL build
>
> Zixun LI (7):
> arm: at91: wdt: Remove unused at91_wdt struct
> arm: at91: wdt: Rename regval in priv data to mr
> watchdog: at91sam9_wdt: Rename priv to wdt
> arm: at91: wdt: Add SAM9X60 register definition
> watchdog: at91sam9_wdt: Add SAM9X60 support
> ARM: dts: sam9x60: Add watchdog DT node.
> ARM: dts: at91: sam9x60-curiosity: Enable watchdog node
>
> arch/arm/dts/at91-sam9x60_curiosity.dts | 5 ++
> arch/arm/dts/sam9x60.dtsi | 7 +++
> arch/arm/mach-at91/include/mach/at91_wdt.h | 25 ++++++----
> drivers/watchdog/at91sam9_wdt.c | 55 +++++++++++++++-------
> 4 files changed, 68 insertions(+), 24 deletions(-)
>
> --
> 2.49.0
>
> ---
> Zixun LI (6):
> arm: at91: wdt: Remove at91_wdt struct
> arm: at91: wdt: Rename regval in priv data to mr
> watchdog: at91sam9_wdt: Rename priv to wdt
> watchdog: at91sam9_wdt: Add SAM9X60 support
> ARM: dts: sam9x60: Add watchdog DT node
> ARM: dts: at91: sam9x60-curiosity: Enable watchdog node
>
> arch/arm/dts/at91-sam9x60_curiosity-u-boot.dtsi | 4 ++
> arch/arm/dts/at91-sam9x60_curiosity.dts | 4 ++
> arch/arm/dts/sam9x60.dtsi | 8 ++++
> arch/arm/mach-at91/include/mach/at91_wdt.h | 25 +++++++----
> arch/arm/mach-at91/spl.c | 4 +-
> drivers/watchdog/at91sam9_wdt.c | 55 ++++++++++++++++++-------
> 6 files changed, 73 insertions(+), 27 deletions(-)
> ---
> base-commit: 10f48365112b164bee6564033ab682747efcb483
> change-id: 20250417-wdt-da6560c1b258
>
> Best regards,
Since you sent the patches apparently there were some changes in the
tree, and now smartweb_defconfig fails.
Could you please check and maybe resend ?
I was ready to apply these but hit this issue.
Thanks,
Eugen
More information about the U-Boot
mailing list