[PATCH v2 3/3] py/tests/test_efi_loader.py: execute HTTP testing

[Adriano Córdova]

Il mer 14 mag 2025, 17:04 Tom Rini <trini at konsulko.com> ha scritto:

> On Wed, May 14, 2025 at 03:45:13AM -0400, Adriano Cordova wrote:
>
> > Execute test_efi_helloworld_net_http
> >
> > Signed-off-by: Adriano Cordova <adriano.cordova at canonical.com>
> > ---
> >
> > v2:
> >  - remove --httpserver option
> >
> >  test/py/tests/test_efi_loader.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/test/py/tests/test_efi_loader.py
> b/test/py/tests/test_efi_loader.py
> > index 91f151d09cd..e19920b4fce 100644
> > --- a/test/py/tests/test_efi_loader.py
> > +++ b/test/py/tests/test_efi_loader.py
> > @@ -195,7 +195,7 @@ def test_efi_helloworld_net_http(ubman):
> >
> >      Call the do_test_efi_helloworld_net function to execute the test
> via HTTP.
> >      """
> > -    if ubman.config.env.get('env__efi_helloworld_net_http_test_skip',
> True):
> > +    if ubman.config.env.get('env__efi_helloworld_net_http_test_skip',
> False):
> >          pytest.skip('helloworld.efi HTTP test is not enabled!')
> >
> >      do_test_efi_helloworld_net(ubman, PROTO_HTTP);
>
> Is this test inverted, or were you unaware of the u-boot-test-hooks side
> at for example:
>
> https://source.denx.de/u-boot/u-boot-test-hooks/-/blob/master/py/travis-ci/u_boot_boardenv_qemu_arm64_na.py?ref_type=heads
>
> --
> Tom
>

I am aware, but as the http server is enabled by 1/3 of this series I
thought this test could default to enabled. Alternatively, or if this
breaks tests where the http server ip is not correctly picked up, this
patch 3/3 can be disregarded and instead selectively enable the test in
u-boot-test-hooks via
env__efi_helloworld_net_http_test_skip = False for at least some boards
(e.g. the ones with qemu with dhcp).

I cared mostly about 1/3 and 2/3 of this series as this would let us test
the EFI_HTTP_PROTOCOL.

Best,
Adriano

>