[PATCH] arm: imx: imx8m: soc: fix the macro name
Quentin Schulz
quentin.schulz at cherry.de
Thu May 15 13:37:44 CEST 2025
Hi Dario,
On 5/15/25 12:02 PM, Dario Binacchi wrote:
> From: Michael Trimarchi <michael at amarulasolutions.com>
>
> The function arch_spl_mmc_get_uboot_raw_sector() was never compiled,
> even when the option CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION was
> enabled. So rename the macro SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION to
> CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION.
>
> Fixes: 2a00d73d081a ("spl: mmc: Try to clean up raw-mode options")
> Signed-off-by: Michael Trimarchi <michael at amarulasolutions.com>
> Signed-off-by: Dario Binacchi <dario.binacchi at amarulasolutions.com>
>
> ---
>
> arch/arm/mach-imx/imx8m/soc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-imx/imx8m/soc.c b/arch/arm/mach-imx/imx8m/soc.c
> index 567e8e9e81a0..806adcf145fa 100644
> --- a/arch/arm/mach-imx/imx8m/soc.c
> +++ b/arch/arm/mach-imx/imx8m/soc.c
> @@ -791,7 +791,7 @@ int boot_mode_getprisec(void)
> #endif
>
> #if defined(CONFIG_IMX8MN) || defined(CONFIG_IMX8MP)
> -#ifdef SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION
> +#ifdef CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION
Maybe a good opportunity to switch to
#if IS_ENABLED(CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION)
?
Reviewed-by: Quentin Schulz <quentin.schulz at cherry.de>
I had a random idea but I'm wondering if there's a way we could check
all symbols listed in IS_ENABLED/CONFIG_IS_ENABLED and check they
actually exist in Kconfig somewhere? This would not have caught this one
since we were using #ifdef but wondering if it could help with
migrations/renaming?
Thanks!
Quentin
More information about the U-Boot
mailing list