[PATCH] ARM: Align image end to 8 bytes to fit DT alignment
Marek Vasut
marek.vasut at mailbox.org
Sun May 18 17:58:35 CEST 2025
On 5/12/25 6:50 PM, Quentin Schulz wrote:
> Hi Marek,
>
> On 5/12/25 6:10 PM, Marek Vasut wrote:
>> Align U-Boot image end to 8 bytes to make sure DT alignment requirement
>> is fulfilled. This fixes a possible failure in fdt_find_separate() in
>> case the U-Boot image is aligned to 4 Bytes and DT is appended at the
>> end at already 8 Byte aligned offset.
>>
>> Signed-off-by: Marek Vasut <marek.vasut at mailbox.org>
>> ---
>> Cc: Ilias Apalodimas <ilias.apalodimas at linaro.org>
>> Cc: Sam Edwards <cfsworks at gmail.com>
>> Cc: Tom Rini <trini at konsulko.com>
>> Cc: u-boot at lists.denx.de
>> ---
>> arch/arm/cpu/u-boot.lds | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/cpu/u-boot.lds b/arch/arm/cpu/u-boot.lds
>> index 817e7a983ae..b2109e03ce3 100644
>> --- a/arch/arm/cpu/u-boot.lds
>> +++ b/arch/arm/cpu/u-boot.lds
>> @@ -153,14 +153,14 @@ SECTIONS
>> __efi_runtime_rel_stop = .;
>> }
>> - . = ALIGN(4);
>> + . = ALIGN(8);
>> __image_copy_end = .;
>> /*
>> * if CONFIG_USE_ARCH_MEMSET is not selected __bss_end -
>> __bss_start
>> * needs to be a multiple of 4 and we overlay .bss with .rel.dyn
>> */
>
> While 8 is a multiple of 4, it's now a bit confusing to have this
> comment just above the following line. Maybe you can update it?
Fixed in V2, thanks for spotting this.
More information about the U-Boot
mailing list