[PATCH v4 1/5] efi: stub: Define debug uart functions only if CONFIG_DEBUG_UART is enabled

[Tom Rini]

On Thu, May 15, 2025 at 05:55:44PM +0200, Lukasz Czechowski wrote:
> Initialize the debug uart only in case CONFIG_DEBUG_UART is
> enabled. The _debug_uart_putc is used internally by debug uart
> functions, so it must be also included inside #ifdef block,
> otherwise it will cause compilation warnings.
> 
> Signed-off-by: Lukasz Czechowski <lukasz.czechowski at thaumatec.com>
> ---
>  lib/efi/efi_stub.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/lib/efi/efi_stub.c b/lib/efi/efi_stub.c
> index 40fc29d9adf7..5172cd78a7c0 100644
> --- a/lib/efi/efi_stub.c
> +++ b/lib/efi/efi_stub.c
> @@ -83,12 +83,14 @@ void puts(const char *str)
>  		putc(*str++);
>  }
>  
> +#ifdef CONFIG_DEBUG_UART
>  static void _debug_uart_putc(int ch)
>  {
>  	putc(ch);
>  }
>  
>  DEBUG_UART_FUNCS
> +#endif
>  
>  void *memcpy(void *dest, const void *src, size_t size)
>  {

I notice that this, and the uniphier implementations are the only
non-inline ones. Is the problem we later conflict with your changes,
perhaps because this wasn't marked inline? Thanks.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250519/b6e3315d/attachment.sig>