[PATCH 4/4] watchdog: don't autostart watchdog on STM32MP boards

[Patrick DELAUNAY]

Hi,

On 5/21/25 14:27, Antonio Borneo wrote:
> From: Patrice Chotard <patrice.chotard at foss.st.com>
>
> The STM32MP2 boards have watchdog started by a previous boot

why only for STM32MP2...

I think it is case for STM32MP1 also.


and in the patch it is the case => default n for ARCH_STM32MP

= all STM32 MPU: STM32MP1(ARMv7) & STM32MP2(ARMv8)


> stage (e.g. bootrom or secure OS), WATCHDOG_AUTOSTART is useless.
> Prefer to rely on DT properties "u-boot,autostart" or "u-boot,noautostart"
> if needed.
>
> Signed-off-by: Patrice Chotard <patrice.chotard at foss.st.com>
> Signed-off-by: Antonio Borneo <antonio.borneo at foss.st.com>
> ---
>   drivers/watchdog/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 1bb67f50352..510330be8a5 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -15,6 +15,7 @@ config WATCHDOG_AUTOSTART
>   	bool "Automatically start watchdog timer"
>   	depends on WDT
>   	default n if ARCH_SUNXI
> +	default n if ARCH_STM32MP
>   	default y
>   	help
>   	  Automatically start watchdog timer and start servicing it during


With this patch you are change the behavior for ALL users of STM32MP arch...

It is OK for any boot with TF-A/OP-TEE....

so for stm32mp15_defconfig/stm32mp15_trusted_defconfig


but what append for boot with SPL on ST boards ?

stm32mp15_basic_defconfig

and what appends for  customer defconfig  with SPL ?

stm32mp15-microgea-stm32mp1-microdev2_defconfig
stm32mp15-icore-stm32mp1-ctouch2_defconfig
stm32mp15_dhcor_basic_defconfig
stm32mp15_dhcom_basic_defconfig
stm32mp15-microgea-stm32mp1-microdev2-of7_defconfig
stm32mp15-icore-stm32mp1-edimm2.2_defconfig

if you want have no impact on other boards, I think a defconfig 
modification is missing for all these defconfig without TF-A/OP-TEE support

CONFIG_WATCHDOG_AUTOSTART=y

or you are expecting STM32MP15 board device tree modification 
("u-boot,autostart") ?


Regards

Patrick