[PATCH v4 15/25] rockchip: rk3399: Adjust initial TPL-stack to match SPL
Jonas Karlman
jonas at kwiboo.se
Sun May 25 21:25:47 CEST 2025
Hi Simon,
On 2025-05-25 12:47, Simon Glass wrote:
> There doesn't seem to be a good reason to use a different value for TPL
> than SPL. Change the TPL value, since it allows a 256-byte bloblist to
> be safely located above the stack in all phases.
As mentioned for prior versions of this, this commit message does not
make any sense with the current state of SPL stack used.
This does not change the TPL stack to match SPL stack, it only moves it
to make room for a 256-byte bloblist used by VBE/VPL.
Please update the commit message and subject to reflect the reason for
this change.
Regards,
Jonas
>
> Note that for most boards, SDRAM init happens in TPL so the SPL stack
> ends up in DRAM, at address CONFIG_SPL_STACK_R_ADDR.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
> (no changes since v2)
>
> Changes in v2:
> - Reword commit to mention comments from Jonas
>
> arch/arm/mach-rockchip/rk3399/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-rockchip/rk3399/Kconfig b/arch/arm/mach-rockchip/rk3399/Kconfig
> index 7b2d47fcb49..cbe718a428a 100644
> --- a/arch/arm/mach-rockchip/rk3399/Kconfig
> +++ b/arch/arm/mach-rockchip/rk3399/Kconfig
> @@ -145,7 +145,7 @@ config TPL_LDSCRIPT
> default "arch/arm/mach-rockchip/u-boot-tpl-v8.lds"
>
> config TPL_STACK
> - default 0xff8effff
> + default 0xff8eff00
>
> config TPL_TEXT_BASE
> default 0xff8c2000
More information about the U-Boot
mailing list