[PATCH v2 0/4] rockchip: Update rng compatible for RK356x and RK3588

[Kever Yang]

Hi Peter,

On 2025/5/29 19:11, Peter Robinson wrote:
> Hi Jonas,
>
> Sorry for the late reply here.
>
> On Tue, 8 Apr 2025 at 23:37, Jonas Karlman <jonas at kwiboo.se> wrote:
>> This series adds support for and updates the random generator compatible
>> used for RK356x and RK3588.
>>
>> The RK356x rng node is already part of dts/upstream so the rng node in
>> u-boot.dtsi is removed, and because it is not enabled for rk3566 it gets
>> enabled in u-boot.dtsi to restore its use in U-Boot.
> It's explicitly disabled in the upstream kernel because it doesn't
> produce actual random data

rockchip trng module is able to pass the third party RNG test, should be 
"actual random data",

so no idea why kernel people think it doesn't produce actual random data.

> and hence upstream believe it shouldn't be
> used, there's a couple of threads on it.
>
> Have we tested to see if the data produced in U-Boot from the HW
> exhibits a different outcome? I wonder if Kever is aware of the kernel
> issue and can provide input.

I only follow linux-rockchip mailing list, so didn't notice the the 
kernel issue.


Thanks,
- Kever
>
> Peter
>
>> The RK3588 rng node is added into dts/upstream DT by picking a commit
>> from devicetree-rebasing v6.15-rc1-dts and the rng node in u-boot.dtsi
>> is removed.
>>
>> Changes in v2:
>> - Split rng driver and DT change into separate patches for RK356x
>> - Pick RK3588 rng node commit from devicetree-rebasing v6.15-rc1-dts
>>
>> Jonas Karlman (3):
>>    rng: rockchip_rng: Add compatible for RK3568
>>    rockchip: rk356x: Remove rng node from u-boot.dtsi
>>    rng: rockchip_rng: Update compatible for RK3588
>>
>> Nicolas Frattaroli (1):
>>    arm64: dts: rockchip: Add rng node to RK3588
>>
>>   arch/arm/dts/rk356x-u-boot.dtsi                  | 9 ++++-----
>>   arch/arm/dts/rk3588s-u-boot.dtsi                 | 5 -----
>>   drivers/rng/rockchip_rng.c                       | 6 +++++-
>>   dts/upstream/src/arm64/rockchip/rk3588-base.dtsi | 8 ++++++++
>>   4 files changed, 17 insertions(+), 11 deletions(-)
>>
>> --
>> 2.49.0
>>