[PATCH v3 1/6] lmb: replace lmb_reserve() and lmb_alloc_addr() API's

Ilias Apalodimas ilias.apalodimas at linaro.org
Fri May 30 09:31:32 CEST 2025


Hi Sughosh

[...]


>         /*
>          * Handle the BOOTM_STATE_FINDOTHER state ourselves as we do not
> diff --git a/cmd/load.c b/cmd/load.c
> index 899bb4f598e..c3ef307bb68 100644
> --- a/cmd/load.c
> +++ b/cmd/load.c
> @@ -178,8 +178,11 @@ static ulong load_serial(long offset)
>  #endif
>                     {
>                         void *dst;
> +                       phys_addr_t addr;

addr is already defined as ulong in this function. You need a
different name here.
But on that why can't you use store_addr directly?

>
> -                       ret = lmb_reserve(store_addr, binlen, LMB_NONE);
> +                       addr = (phys_addr_t)store_addr;
> +                       ret = lmb_alloc_mem(LMB_MEM_ALLOC_ADDR, 0, &addr,
> +                                           binlen, LMB_NONE);
>                         if (ret) {
>                                 printf("\nCannot overwrite reserved area (%08lx..%08lx)\n",
>                                         store_addr, store_addr + binlen);

[...]

Thanks
/Ilias


More information about the U-Boot mailing list