[PATCH RFC v2 2/8] tools: binman: drop "faked" return value from check_fake_fname

Simon Glass sjg at chromium.org
Fri May 30 13:18:01 CEST 2025


Hi Yannic,

On Tue, 27 May 2025 at 14:24, Yannic Moog <y.moog at phytec.de> wrote:
>
> check_fake_fname sets the faked member of the entry. Use that member
> to get the faked status instead of a returned value indicating the same.
> Add type annotations to the modified functions while at it.
>
> Signed-off-by: Yannic Moog <y.moog at phytec.de>
> ---
>  tools/binman/entry.py               | 11 +++++------
>  tools/binman/etype/blob.py          |  7 +++----
>  tools/binman/etype/blob_ext_list.py |  4 ++--
>  3 files changed, 10 insertions(+), 12 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

For the commit message, single quotes and <=60 chars are preferred. How about:

tools: binman: Don't return 'faked' from check_fake_fname()


More information about the U-Boot mailing list