[PATCH v6 2/3] efi_var: Unify read/write access helper function
Michal Simek
michal.simek at amd.com
Tue Feb 3 12:45:55 CET 2026
On 2/3/26 12:29, Maarten Brock wrote:
>> -----Original Message-----
>> From: Michal Simek <michal.simek at amd.com>
>> Sent: Tuesday 3 February 2026 11:10
>> To: Maarten Brock <Maarten.Brock at sttls.nl>; u-boot at lists.denx.de;
>> git at amd.com
>> Cc: Ilias Apalodimas <ilias.apalodimas at linaro.org>; Heinrich Schuchardt
>> <xypron.glpk at gmx.de>; Shantur Rathore <i at shantur.com>; Tom Rini
>> <trini at konsulko.com>
>> Subject: Re: [PATCH v6 2/3] efi_var: Unify read/write access helper function
>>
>> Hi,
>>
>> On 2/3/26 10:44, Maarten Brock wrote:
>>> Hello Michal,
>>>
>>> Why are the new function names non-symmetrical?
>>> efi_var_to_storage <-> efi_var_from ...
>>
>> Ilias was asking about these names in v5 review.
>
> I'm sure he meant something different from what you implemented.
>
>> I am ok with this with a small nit.
>> Can we rename efi_var_read/write to efi_var_from/to_storage? I want to
>> make it clealer what these functions are used for
>>
>> With the changes above
>> Reviewed-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>
>
> I think Ilias meant to use:
> efi_var_from_storage & efi_var_to_storage
> and not:
> efi_var_from & efi_var_to_storage
You are likely right. Let me fix that.
Thanks,
Michal
More information about the U-Boot
mailing list