[PATCH v2 0/2] net: lwip: Do not write past end of buffer
Jerome Forissier
jerome at forissier.org
Wed Feb 4 09:03:51 CET 2026
Hi,
On 2/3/26 19:39, Tom Rini wrote:
> On Tue, Feb 03, 2026 at 07:35:19PM +0100, Michal Simek wrote:
>> Hi Jerome,
>>
>> st 14. 1. 2026 v 16:12 odesílatel Andrew Goodbody
>> <andrew.goodbody at linaro.org> napsal:
>>>
>>> Fix some cases where the trailing \0 written by sprintf is not allowed
>>> for in the target buffer resulting in writing past the end of the
>>> buffer.
>>>
>>> Signed-off-by: Andrew Goodbody <andrew.goodbody at linaro.org>
>>> ---
>>> Changes in v2:
>>> - Address review comments from Michal Simek
>>> - Add a second patch to address some more instances of sprintf writing
>>> past the end of the target buffer found by code inspection while
>>> looking for an issue.
>>> - Link to v1: https://lore.kernel.org/r/20260109-tftp_fix-v1-1-64bd50abc72b@linaro.org
>>>
>>> ---
>>> Andrew Goodbody (2):
>>> net: lwip: tftp: Do not write past buffer end
>>> net: lwip: dhcp: Do not write past end of buffer
>>>
>>> lib/lwip/lwip/src/apps/tftp/tftp.c | 2 +-
>>> net/lwip/dhcp.c | 6 +++---
>>> net/lwip/net-lwip.c | 6 +++---
>>> 3 files changed, 7 insertions(+), 7 deletions(-)
>>> ---
>>> base-commit: c05dba22f1f2b0b2655ee3971644acf1936cd07a
>>> change-id: 20260109-tftp_fix-3ab9bd66a6ad
>>>
>>> Best regards,
>>> --
>>> Andrew Goodbody <andrew.goodbody at linaro.org>
>>>
>>
>> Are you going to apply it? I would be good to get it in.
Sorry Michal your email ended up in my spam folder :-/
>
> I'll second that ask since it's what's keeping:
> https://source.denx.de/u-boot/u-boot/-/jobs/1370910
> failing and not passing.
I'll send a pull request today.
Thanks,
--
Jerome
More information about the U-Boot
mailing list