[PATCH 2/2] Fix x86 baytrail boot flow, UPD/VPD Updates

[Tom Rini]

On Tue, Feb 10, 2026 at 02:38:51PM +0000, Eric Schikschneit wrote:
> Hello Simon, Tom,
> 
> 1. Tom -
> > And we should spell out that device tree can't set these any more in the
> > commit message, along with spelling out why we can't do that anymore
> > safely (why can't we?). Thanks.
> I would be happy to move the code comment into the commit message:
>  /* NOTE: This breaks u-boot ability to set board options via    *
>   * device tree, but guarantees specific known values..          *
>   * you wouldnt use an uninitialized variable would you??        */
> These settings could be set by device tree, but every fdtdec* function must
> set a valid value. If a user has something set differently than called out in the
> FSP_MR5 Integration Guide the board stability will be compromised. Many of
> these settings are co-dependant so we would need much more robust error
> checking. This task would not be trivial. By using the specific values called out
> by the Integration guide we allow users to begin from a documented known
> good configuration. Maybe we could set all the values, and then check the
> device tree to see if the user specified a different value? If the device tree does
> not call out a specific setting we would not want to just set it to zero for example
> as this can cause undefined behavior.

That would make a good commit message, thanks.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20260210/9a01f517/attachment.sig>