[PATCH v2 01/12] rockchip: board: qnap-ts433: Fix TPL binary in build-example

[Quentin Schulz]

Hi Heiko,

On 1/14/26 9:28 AM, Heiko Stuebner wrote:
> In the example on how to modify the serial-console in the TPL binary
> we already use the v1.21 of the 1560MHz DDR-init binary.
> 
> Yet in the build-example the TPL link goes to v1.13 of the 1056MHz
> DDR-init.
> 

May I suggest to set BL31 earlier, such that one can use $BL31 as 
parameter to tools/ddrbin_tool and we don't need to worry about having 
them out of sync?

Also, both are for versions that are not the latest in rkbin git repo.
May I suggest to provide the commit hash to checkout for this to work, 
or to adapt the instructions to use the latest available binary?
See the instructions for Jaguar for example. Also, there's a sed command 
there which is probably more user-friendly than asking the user to 
manually patch the file with a diff?

Same for BL31 for that matter.

Also the ddbin_tool is now a python script with different arguments, so 
you'll need to update that as well.

And the version of the spl_loader file will probably also be different.

Finally, how about using the usb-471 and usb-472 binaries we now 
generate instead of the output of tools/boot_merger with the default 
binaries from rkbin?

I'm wondering if we shouldn't reverse engineer tools/boot_merger so we 
can generate an image usable with rkdeveloptool straight out of binman 
for example.

Only suggestions (highly recommend either hardcoding the commit hash or 
using globs/logic to find the appropriate file from latest version in 
the repo), thus:

Reviewed-by: Quentin Schulz <quentin.schulz at cherry.de>

Thanks!
Quentin