[PATCH v2 05/12] rockchip: board: qnap-ts433: Add instructions for how to use upstream TF-A

[Quentin Schulz]

Hi Heiko,

On 1/14/26 9:28 AM, Heiko Stuebner wrote:
> Upstream TF-A has basic support for RK3568 for a while, but only with the
> last release finally gained also cpufreq support.
> 
> The only known missing piece is enabling the ARM crypto extensions,
> but otherwise upstream TF-A is fully usable now.
> 

Missing ARM crypto extensions means crypto stuff is going to be slower, 
not broken right?

> So steal and adapt Quentin's wording from tiger-rk3588 on how to use
> either upstream or vendor TF-A.
> 

I see you carefully removed the logic to detect the proper file to use 
without having to hardcode the version number though ;)

> Signed-off-by: Heiko Stuebner <heiko at sntech.de>
> ---
>   doc/board/qnap/ts433.rst | 28 +++++++++++++++++++++++++++-
>   1 file changed, 27 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/board/qnap/ts433.rst b/doc/board/qnap/ts433.rst
> index 2cd7cf13d67..5c81dc953a6 100644
> --- a/doc/board/qnap/ts433.rst
> +++ b/doc/board/qnap/ts433.rst
> @@ -39,17 +39,43 @@ modification and also a new maskrom downloader can be build:
>       $ tools/ddrbin_tool.py rk3568 tools/ddrbin_param.txt bin/rk35/rk3568_ddr_1560MHz_v1.23.bin
>       $ tools/boot_merger RKBOOT/RK3568MINIALL.ini
>   
> +Get TF-A
> +--------
> +
> +There are two possible options, pick one or the other.
> +
> +Prebuilt binary from Rockchip
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +
> +.. prompt:: bash
> +
> +   $ export BL31=../rkbin/bin/rk35/rk3568_bl31_v1.45.elf
> +
> +Upstream
> +~~~~~~~~
> +
> +.. prompt:: bash
> +
> +   git clone https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git
> +   cd trusted-firmware-a
> +   make CROSS_COMPILE=aarch64-linux-gnu- PLAT=rk3568 bl31
> +   export BL31=$PWD/build/rk3568/release/bl31/bl31.elf
> +
>   Building U-Boot
>   ---------------
>   
>   .. code-block:: bash
>   
>       $ export CROSS_COMPILE=aarch64-linux-gnu-
> -    $ export BL31=../rkbin/bin/rk35/rk3568_bl31_v1.45.elf
>       $ export ROCKCHIP_TPL=../rkbin/bin/rk35/rk3568_ddr_1560MHz_v1.23.bin
>       $ make qnap-ts433-rk3568_defconfig
>       $ make
>   
> +.. note::
> +   If using upstream TF-A, one should disable ``SPL_ATF_NO_PLATFORM_PARAM`` symbol in
> +   U-Boot config (via e.g. ``make CROSS_COMPILE=aarch64-linux-gnu- menuconfig``) which
> +   will, among other things, enable console output in TF-A.
> +

Wondering if we shouldn't add a config fragment which disables that, 
such that it's easier for the user (and can be part of build systems).

In any case, unrelated, so:

Reviewed-by: Quentin Schulz <quentin.schulz at cherry.de>

Thanks!
Quentin