[PATCH] rockchip: rk3588-rock-5b: Remove USB-C controller from u-boot.dtsi
Jonas Karlman
jonas at kwiboo.se
Fri Feb 13 18:42:32 CET 2026
Hi Quentin,
On 2/13/2026 6:17 PM, Quentin Schulz wrote:
> Hi Jonas,
>
> On 1/26/26 10:55 PM, Jonas Karlman wrote:
>
> [...]
>
>> -&usb_host0_xhci {
>> - dr_mode = "peripheral";
>> - maximum-speed = "high-speed";
>
> This is not set anymore after this patch is applied (dr_mode = otg and
> no maximum-speed). Please keep this part as is and if actually fine to
> remove, have a separate commit motivating the removal.
I disagree, these props may differ but the function they result in for
U-Boot is the same, i.e. ums and rockusb commands can be used before and
after this patch.
The board u-boot.dtsi included something minimal required to have ums
and rockusb working, this can fully be replaced with upstream DT and
U-Boot functionality stay the same. Something I think current commit
message is already covering.
Regards,
Jonas
> Cheers,
> Quentin
More information about the U-Boot
mailing list