[PATCH v2 05/11] imx8qxp_capricorn config: add wget command

[Heiko Schocher]

Hello Marek,

On 16.02.26 11:15, Marek Vasut wrote:
> On 2/14/26 5:56 AM, Heiko Schocher wrote:
>> From: Walter Schweizer <walter.schweizer at siemens.com>
>>
>> Faster than tftp.
> 
> The commit message could use an improvement .

changed to
"""
We enable the wget command since it is faster than TFTP transfers.
"""

> 
>> Signed-off-by: Walter Schweizer <walter.schweizer at siemens.com>
>> Reviewed-by: Peng Fan <peng.fan at nxp.com>
>>
>> Signed-off-by: Heiko Schocher <hs at nabladev.com>
>> ---
>>
>> Changes in v2:
>> Added Reviewed-by from Peng
>>
>>   configs/imx8qxp_capricorn.config | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/configs/imx8qxp_capricorn.config b/configs/imx8qxp_capricorn.config
>> index 62babf2626f..b5c9fdbc9b3 100644
>> --- a/configs/imx8qxp_capricorn.config
>> +++ b/configs/imx8qxp_capricorn.config
>> @@ -73,6 +73,7 @@ CONFIG_CMD_CPU=y
>>   # CONFIG_CMD_CRC32 is not set
>>   # CONFIG_CMD_BIND is not set
>>   CONFIG_CMD_WDT=y
>> +CONFIG_CMD_WGET=y
> Do you also have CONFIG_PROT_TCP_SACK=y enabled ?

No, I see in .config:

CONFIG_PROT_TCP=y
# CONFIG_PROT_TCP_SACK is not set

doc says:
"""
TCP Selective Acknowledgments in the legacy network stack can be enabled via
CONFIG_PROT_TCP_SACK=y. This will improve the download speed. Selective
Acknowledgments are enabled by default with lwIP.
"""

Ah, thanks for the hint!

@Adrian @Walter: May you can test this if it speeds up wget?


> Also, keep in mind, if/once you will switch to LWIP, the wget command syntax changes sightly (sigh).

Uff...

Thanks for the review!

bye,
Heiko
-- 
Nabla Software Engineering
HRB 40522 Augsburg
Phone: +49 821 45592596
E-Mail: office at nabladev.com
Geschäftsführer : Stefano Babic