[PATCH v1] net: phy: air_en8811: add support for Airoha AN8811HB PHY

[Tommy Shih (施易廷)]

Hi Daniel
Thank you for pointing this out. I will check and remove the additional headers in the next version.

-----Original Message-----
From: Daniel Golle <daniel at makrotopia.org> 
Sent: Tuesday, February 24, 2026 8:01 PM
To: Tommy Shih (施易廷) <tommy.shih at airoha.com>
Cc: Christian Marangi <ansuelsmth at gmail.com>; Jerome Forissier <jerome.forissier at arm.com>; Joe Hershberger <joe.hershberger at ni.com>; Lucien . Jheng <lucienzx159 at gmail.com>; Marek Vasut <marek.vasut+renesas at mailbox.org>; Ramon Fried <rfried.dev at gmail.com>; Tom Rini <trini at konsulko.com>; frank-w at public-files.de; u-boot at lists.denx.de; Lucien Jheng (鄭祥鈞) <lucien.jheng at airoha.com>
Subject: Re: [PATCH v1] net: phy: air_en8811: add support for Airoha AN8811HB PHY


External email : Please do not click links or open attachments until you have verified the sender or the content.


On Tue, Feb 24, 2026 at 07:02:50PM +0800, Tommy Shih wrote:
> Add support for the Airoha AN8811HB 2.5 Gigabit PHY to the existing 
> en8811h driver. This PHY supports 10/100/1000/2500 Mbps speeds.
>
> Update the driver to recognize the AN8811HB PHY ID and handle its 
> specific firmware loading requirements. The firmware loading mechanism 
> remains consistent with the existing implementation.
>
> This driver is based on:
>   - Linux upstream PHY subsystem (v7.0-rc1)
>   - air_an8811hb v0.0.4 out-of-tree uboot driver written by
>     "Lucien.Jheng <lucien.jheng at airoha.com>"
>
> Tested on MT7987 RFB board.
>
> Link: 
> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kerne
> l/git/next/linux-next.git/commit/?id=6f1769ec5892ac41d82e820d94dcdc68e
> 904aa99__;!!CTRNKA9wMg0ARbw!mEnAw9tiFMEFMmZknVNPPxkzu37z3Pr9_L6Azy_fo0
> 1EJAXaVdNbeov2Lp3WKHRb04O4OmfTitaIooepMIg$
> Link: 
> https://urldefense.com/v3/__https://patchwork.kernel.org/project/netde
> vbpf/patch/20260122071601.1057083-3-bjorn at mork.no/__;!!CTRNKA9wMg0ARbw
> !mEnAw9tiFMEFMmZknVNPPxkzu37z3Pr9_L6Azy_fo01EJAXaVdNbeov2Lp3WKHRb04O4O
> mfTitaIh73KJlI$
> Signed-off-by: Tommy Shih <tommy.shih at airoha.com>
> Reviewed-by: Lucien.Jheng <lucienzx159 at gmail.com>
>
> ---
>
>  drivers/net/phy/airoha/Kconfig      |   2 +-
>  drivers/net/phy/airoha/air_en8811.c | 695 
> ++++++++++++++++++++++++++--
>  2 files changed, 652 insertions(+), 45 deletions(-)
>
> diff --git a/drivers/net/phy/airoha/Kconfig 
> b/drivers/net/phy/airoha/Kconfig index 999564e4848..fcace9a24ac 100644
> --- a/drivers/net/phy/airoha/Kconfig
> +++ b/drivers/net/phy/airoha/Kconfig
> @@ -8,4 +8,4 @@ config PHY_AIROHA_EN8811
>       select FW_LOADER
>       help
>         AIROHA EN8811H supported.
> -
> +       AIROHA AN8811HB supported.
> diff --git a/drivers/net/phy/airoha/air_en8811.c 
> b/drivers/net/phy/airoha/air_en8811.c
> index 1a628ede82b..974887da33d 100644
> --- a/drivers/net/phy/airoha/air_en8811.c
> +++ b/drivers/net/phy/airoha/air_en8811.c
> @@ -1,46 +1,37 @@
>  // SPDX-License-Identifier: GPL-2.0+
>  /*
> - * Driver for the Airoha EN8811H 2.5 Gigabit PHY.
> + * Driver for the Airoha EN8811H and AN8811HB 2.5 Gigabit PHY.
>   *
> - * Limitations of the EN8811H:
> + * Limitations:
>   * - Only full duplex supported
>   * - Forced speed (AN off) is not supported by hardware (100Mbps)
>   *
>   * Source originated from linux air_en8811h.c
>   *
> - * Copyright (C) 2025 Airoha Technology Corp.
> + * Copyright (C) 2025, 2026 Airoha Technology Corp.
>   */
> -
>  #include <phy.h>
>  #include <errno.h>
>  #include <log.h>
>  #include <env.h>
>  #include <malloc.h>
> +#include <fs.h>

I don't see where you are using anything provided by the fs.h header.

>  #include <fw_loader.h>
>  #include <asm/unaligned.h>
> +#include <version.h>
> +#include <linux/delay.h>
>  #include <linux/iopoll.h>
>  #include <linux/bitops.h>
> +#include <linux/bitfield.h>
>  #include <linux/compat.h>
> +#include <linux/kernel.h>

... and for sure you don't need that one.

>  #include <dm/device_compat.h>
>  #include <u-boot/crc.h>

Please carefully check which additional headers are actually needed.