[PATCH] pinctrl: mediatek: fix compilation issue

[Tom Rini]

On Thu, Dec 11, 2025 at 10:16:42AM +0100, Julien Stephan wrote:

> When compiling the pinctrl driver for mt7981/mt7986/mt7987/mt7988
> we have the following errors:
> 
>   error: ‘const struct mtk_io_type_desc’ has no member named ‘bias_set’
>   error: ‘const struct mtk_io_type_desc’ has no member named ‘drive_set’
>   error: ‘const struct mtk_io_type_desc’ has no member named ‘input_enable’
> 
> Fix this by selecting PINCONF in the appropriate config.
> 
> Signed-off-by: Julien Stephan <jstephan at baylibre.com>
> ---
>  drivers/pinctrl/mediatek/Kconfig | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig
> index 8b9180bd2aaeb56325ba42d08afa42d9317f23a1..026ddbddb2cf1f489e4e22a6ef2b407fb96daf11 100644
> --- a/drivers/pinctrl/mediatek/Kconfig
> +++ b/drivers/pinctrl/mediatek/Kconfig
> @@ -18,18 +18,22 @@ config PINCTRL_MT7629
>  
>  config PINCTRL_MT7981
>  	bool "MT7981 SoC pinctrl driver"
> +	select PINCONF
>  	select PINCTRL_MTK
>  
>  config PINCTRL_MT7986
>  	bool "MT7986 SoC pinctrl driver"
> +	select PINCONF
>  	select PINCTRL_MTK
>  
>  config PINCTRL_MT7987
>  	bool "MT7987 SoC pinctrl driver"
> +	select PINCONF
>  	select PINCTRL_MTK
>  
>  config PINCTRL_MT7988
>  	bool "MT7988 SoC pinctrl driver"
> +	select PINCONF
>  	select PINCTRL_MTK
>  
>  config PINCTRL_MT8512

OK, so looking at drivers/pinctrl/mediatek/Kconfig we need to fix that,
as the logic is all wrong. We can't have PINCTRL_MTK depend on
PINCTRL_GENERIC and then all these drivers select it. All these drivers
should depends on PINCTRL_GENERIC, which is how other platforms handle
it. It's debatable if they should also "depends on PINCONF" or "select
PINCONF" but the common case today is "select PINCONF", so do that for
all of the mediatek drivers here which also need it. Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20260102/b258fc65/attachment.sig>