[FYI] ufs: rename split across commits

Neil Armstrong neil.armstrong at linaro.org
Wed Jan 7 19:00:45 CET 2026


On 1/7/26 12:45, Marek Vasut wrote:
> On 1/7/26 7:06 AM, Kunihiko Hayashi wrote:
>> Hi all,
> 
> Hello Hayashi-san,
> 
>> While reviewing ufs history on main, I noticed something that might confuse
>> future readers:
>>
>>   commit 1de63f1be48b
>>      Message says "Rename ufs.c to ufs-uclass.c", but diff only deletes ufs.c
>>   commit 067c1b033282
>>      Adds ufs-uclass.c together with .post_bind changes
>>
>> So the rename is effectively split across two commits. No functional issue,
>> just a heads-up for anyone using blame or rename detection.
>>
>> Sorry for the noise if this has already been discussed.
> 
> That is a nice find, thank you for keeping an eye on these commits.
> 
> Indeed, this seems like some sort of an application error due to file renaming.
> 
> You are right, the resulting ufs-uclass.c is what it should be.
> 
> Niel, do you know what happened ?
> 

Somehow the rename failed when I applied:

see my b4 ty at: https://lore.kernel.org/all/176167065011.4104072.12154709648586611964.b4-ty@linaro.org/
and the actual ufs-class file was added back on the next commit...

Will check twice next time to avoid this.

Thx for reporting this,
Neil


More information about the U-Boot mailing list