[PATCH v2] ufs: uclass: fix potential unitialised use

Marek Vasut marek.vasut at mailbox.org
Thu Jan 8 21:35:43 CET 2026


On 1/8/26 9:14 PM, Casey Connolly wrote:

[...]

>   	host_ref_clk_freq = ufshcd_parse_dev_ref_clk_freq(hba, ref_clk);
> -	if (host_ref_clk_freq == REF_CLK_FREQ_INVAL)
> +	if (host_ref_clk_freq == REF_CLK_FREQ_INVAL) {
>   		dev_err(hba->dev,
>   			"invalid ref_clk setting = %ld\n", clk_get_rate(ref_clk));
> -
> -	if (host_ref_clk_freq == REF_CLK_FREQ_INVAL)
> -		goto out;
> +		/* FIXME: qcom platforms don't have this wired up yet but seem to work anyway */
> +		return 0;
> +	}
Please see my comment on V1.

The rest of the patch is OK, thank you !


More information about the U-Boot mailing list