[PATCH v2] binman: elf: Check for ELF_TOOLS availability in is_valid
Dmitrii Sharshakov
d3dx12.xx at gmail.com
Fri Jan 9 23:03:28 CET 2026
Check if elftools package is available before running DecodeElf().
This clarifies the error message.
Signed-off-by: Dmitrii Sharshakov <d3dx12.xx at gmail.com>
---
Make the error more informative and indicative of environment issue and
not a code one
---
Changes in v2:
- Reword the commit message as suggested by reviewers
- Link to v1: https://lore.kernel.org/r/20260109-pyelftools-warning-v1-1-1a4965609b55@gmail.com
---
tools/binman/elf.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/binman/elf.py b/tools/binman/elf.py
index 6ac960e0419..899c84ad36d 100644
--- a/tools/binman/elf.py
+++ b/tools/binman/elf.py
@@ -570,6 +570,8 @@ def is_valid(data):
Returns:
bool: True if a valid Elf file, False if not
"""
+ if not ELF_TOOLS:
+ raise ValueError("Python: No module named 'elftools'")
try:
DecodeElf(data, 0)
return True
---
base-commit: 1bcb2fe324180d0a8cfbdb0511737eba1d5b8550
change-id: 20260109-pyelftools-warning-6df5f57ca5b8
Best regards,
--
Dmitrii Sharshakov <d3dx12.xx at gmail.com>
More information about the U-Boot
mailing list