[PATCH v2 1/2] pinctrl: mediatek: kconfig: fix logic

[Quentin Schulz]

Hi Julien,

On 1/8/26 3:47 PM, Julien Stephan wrote:
> We can't have PINCTRL_MTK depend on PINCTRL_GENERIC and then all
> drivers select it. Individual drivers should directly depend on
> PINCTRL_GENERIC.
> 
> Signed-off-by: Julien Stephan <jstephan at baylibre.com>
> ---
>   drivers/pinctrl/mediatek/Kconfig | 21 ++++++++++-----------
>   1 file changed, 10 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig
> index 8b9180bd2aaeb56325ba42d08afa42d9317f23a1..d10d08d9fe80441a5a2f8acc13e312825fa43a5d 100644
> --- a/drivers/pinctrl/mediatek/Kconfig
> +++ b/drivers/pinctrl/mediatek/Kconfig
> @@ -1,47 +1,46 @@
>   if ARCH_MEDIATEK
>   
>   config PINCTRL_MTK
> -	depends on PINCTRL_GENERIC
>   	bool
>   

Are you sure this still works?

Since nothing selects PINCTRL_MTK anymore and this boolean isn't 
selectable (doesn't have a prompt) and there's no default (Kconfig 
defaults to n when it's missing), how are the drivers/pinctrl/mediatek/ 
going to be reached (see drivers/pinctrl/Makefile) and 
pinctrl-mtk-common.o be compiled?

Maybe you want something similar to what we've done for Rockchip maybe?

Have only one symbol for all drivers but only build the SoC-specific 
driver if the symbol for the SoC is selected? (this will also make it 
easier to have SPL_PINCTRL_MTK for example (don't have to have a symbol 
for each SoC). Using CONFIG_TARGET_MTxxxx for example? Something akin to 
what's done for the clock framework already for Mediatek, just with the 
additional PINCTRL_MTK symbol?

Cheers,
Quentin