[PATCH v4 4/6] binman: Add dump signarture option to mkeficapsule

[Quentin Schulz]

Hi Wojciech,

On 1/20/26 9:12 AM, Wojciech Dubowik wrote:
> It will be used to capsule signature verification.
> 
> Signed-off-by: Wojciech Dubowik <Wojciech.Dubowik at mt.com>
> ---
>   tools/binman/btool/mkeficapsule.py | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/binman/btool/mkeficapsule.py b/tools/binman/btool/mkeficapsule.py
> index f7e5a8868495..f4b594b3faef 100644
> --- a/tools/binman/btool/mkeficapsule.py
> +++ b/tools/binman/btool/mkeficapsule.py
> @@ -38,7 +38,8 @@ class Bintoolmkeficapsule(bintool.Bintool):
>   
>       def generate_capsule(self, image_index, image_guid, hardware_instance,
>                            payload, output_fname, priv_key, pub_key,
> -                         monotonic_count=0, version=0, oemflags=0):
> +                         monotonic_count=0, version=0, oemflags=0,
> +                         dump_sig=0):

This is clearly a boolean flag both in tools/mkeficapsule.c, the 
dump-signature boolean property added in the next patch and how it's 
stored in Entry_efi_capsule object, so please make this a bool.

>           """Generate a capsule through commandline-provided parameters
>   
>           Args:
> @@ -53,6 +54,7 @@ class Bintoolmkeficapsule(bintool.Bintool):
>               monotonic_count (int): Count used when signing an image
>               version (int): Image version (Optional)
>               oemflags (int): Optional 16 bit OEM flags
> +            dump_sig (int): Dump signature to a file (Optional)

Ditto.

Also, specify the default value (false).

Cheers,
Quentin