[PATCH v1] env: add w flags for net config in explicit write mode
Heiko Schocher
hs at nabladev.com
Sun Jan 25 14:03:36 CET 2026
Hello Benjamin,
On 24.01.26 12:35, Benjamin ROBIN wrote:
> Hello,
>
> On Saturday, January 24, 2026 at 6:40 AM, Heiko Schocher wrote:
>> From: Adrian Freihofer <adrian.freihofer at siemens.com>
>>
>> In explicit write access mode (CONFIG_ENV_WRITEABLE_LIST) the
>> environment variables listed in NET_FLAGS and NET6_FLAGS are
>> probably intended to be writeable. Therefore add the 'w' flag
>> to these variables.
>
> Users who enable CONFIG_ENV_WRITEABLE_LIST typically want full control over
> which environment variables are writable. The new default behavior introduced
> by your patch might not align with what all users expect or want.
>
> Would overriding the flags using CFG_ENV_FLAGS_LIST_STATIC not work in this
> case?
Good question, I have to test... or may Adrian has already done
such tests...
But looking into code.. if we add this variables in ENV_WRITEABLE_LIST
the results would be, that this variables are twice in ENV_FLAGS_LIST_STATIC
include/env_flags.h
87 #define ENV_FLAGS_LIST_STATIC \
88 ETHADDR_FLAGS \
89 NET_FLAGS \
90 NET6_FLAGS \
91 SERIAL_FLAGS \
92 CFG_ENV_FLAGS_LIST_STATIC
once through NET_FLAGS and once through CFG_ENV_FLAGS_LIST_STATIC
So, that is not good, and I think, code will find the first
entry, and parse it -> so it will not work.
Should we instead in case CONFIG_ENV_WRITEABLE_LIST is enabled
only set/allow CFG_ENV_FLAGS_LIST_STATIC in ENV_FLAGS_LIST_STATIC ?
bye,
Heiko
--
Nabla Software Engineering
HRB 40522 Augsburg
Phone: +49 821 45592596
E-Mail: office at nabladev.com
Geschäftsführer : Stefano Babic
More information about the U-Boot
mailing list