[PATCH v2] cmd: unzip: Use map_sysmem() with buffers in the gzwrite command

Marek Vasut marek.vasut+renesas at mailbox.org
Wed Jan 28 20:41:04 CET 2026


The current implementation casts an address to a pointer. Make it more
sandbox-friendly by using map_sysmem().

Convert 'addr' variable to unsigned long, as that is the return type of
hextoul() and address parameter type of map_sysmem().

Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>
---
Cc: Alexander Graf <agraf at csgraf.de>
Cc: Heinrich Schuchardt <xypron.glpk at gmx.de>
Cc: Ilias Apalodimas <ilias.apalodimas at linaro.org>
Cc: Jerome Forissier <jerome at forissier.org>
Cc: Mattijs Korpershoek <mkorpershoek at kernel.org>
Cc: Neil Armstrong <neil.armstrong at linaro.org>
Cc: Peng Fan <peng.fan at nxp.com>
Cc: Quentin Schulz <quentin.schulz at cherry.de>
Cc: Simon Glass <sjg at chromium.org>
Cc: Tom Rini <trini at konsulko.com>
Cc: Yuya Hamamachi <yuya.hamamachi.sx at renesas.com>
Cc: u-boot at lists.denx.de
---
V2: Add missing unmap_sysmem()
---
 cmd/unzip.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/cmd/unzip.c b/cmd/unzip.c
index da958f12803..ba83995040b 100644
--- a/cmd/unzip.c
+++ b/cmd/unzip.c
@@ -50,11 +50,12 @@ static int do_gzwrite(struct cmd_tbl *cmdtp, int flag,
 {
 	struct blk_desc *bdev;
 	int ret;
-	unsigned char *addr;
+	unsigned long addr;
 	unsigned long length;
 	unsigned long writebuf = 1<<20;
 	off_t startoffs = 0;
 	size_t szexpected = 0;
+	void *addrp;
 
 	if (argc < 5)
 		return CMD_RET_USAGE;
@@ -62,7 +63,7 @@ static int do_gzwrite(struct cmd_tbl *cmdtp, int flag,
 	if (ret < 0)
 		return CMD_RET_FAILURE;
 
-	addr = (unsigned char *)hextoul(argv[3], NULL);
+	addr = hextoul(argv[3], NULL);
 	length = hextoul(argv[4], NULL);
 
 	if (5 < argc) {
@@ -75,7 +76,11 @@ static int do_gzwrite(struct cmd_tbl *cmdtp, int flag,
 		}
 	}
 
-	ret = gzwrite(addr, length, bdev, writebuf, startoffs, szexpected);
+	addrp = map_sysmem(addr, length);
+
+	ret = gzwrite(addrp, length, bdev, writebuf, startoffs, szexpected);
+
+	unmap_sysmem(addrp);
 
 	return ret ? CMD_RET_FAILURE : CMD_RET_SUCCESS;
 }
-- 
2.51.0



More information about the U-Boot mailing list