[PATCH v7 0/5] Added QCOM RPMH Power Domain Driver

[Aswin Murugan]

Hi Casey,

Thanks for the review & feedback

Regarding comment *#2*, this was already discussed in v5 [1] and got 
addressed from v6.
In Patch No 2 "power-domain: Add warning when power-domain driver is 
missing", |dev_power_domain_ctrl()| was updated to log a warning when 
the power‑domain driver isn’t found (|-ENODEV|) and return 0 so that 
execution continues without breaking the rpmpd platforms.

For the remaining comments (#1 and #3), I’ll incorporate the suggestions 
and respin the series.

[1] 
https://lore.kernel.org/u-boot/2e387aeb-2ba2-4b72-aa91-0815cd06f831@linaro.org/

Regards,
Aswin

On 1/14/2026 8:08 PM, Casey Connolly wrote:
> Hi Aswin,
>
> Sorry for the late response here.
>
> Still a few minor issues with this series but it's more or less there.
> I'll just list everything here rather than replying to individual patches.
>
> 1. Please rename the kconfig option to something more specific like
> QCOM_RPMH_POWER_DOMAIN
> 2. Removing the fixup code will break msm8916 and other platforms that
> use rpmpd (non-hardened), it should be pretty trivial to check if the
> compatible string for the power-controller node ends with "rpmpd" or
> "rpmhpd" and skip the logic in the latter case.
> 3. The commit "mach-snapdragon: fixup power-domains" should have a more
> specific title.
>
> I'll pick this up as soon as I get the next revision.
>
> Kind regards,
>
> On 22/12/2025 12:48, Aswin Murugan wrote:
>> This patch series adds support for the Qualcomm RPMH power domain
>> driver, responsible for managing power domains on Qualcomm SoCs.
>> The driver is ported from the Linux kernel and adapted for
>> U-Boot to enable proper power domain control on SA8775P platform.
>>
>> Signed-off-by: Aswin Murugan <aswin.murugan at oss.qualcomm.com>
>> ---
>> Changes in v7:
>> - Droped soc: qcom: cmd-db: Add cmd_db_read_slave_id() & cmd_db_read_aux_data() functions
>>    patch from previous version, since it was already picked
>>    Link: https://lore.kernel.org/u-boot/176363183220.2293399.7296647117885059868.b4-ty@linaro.org/
>> - Cleaned up the warning logic in drivers/power/domain/power-domain-uclass.c
>>    when power-domain driver is missing
>> - Link to v6: https://lore.kernel.org/u-boot/20251113113427.2218045-1-aswin.murugan@oss.qualcomm.com/
>>
>> Changes in v6:
>> - Added the change in drivers/power/domain/power-domain-uclass.c to give warning
>>    when power-domain driver is missing
>> - Added the change log 'In qcom-rpmhpd driver, the un-supported power domains are handled with warning
>>    in rpmhpd_power_on() & rpmhpd_power_on()'
>> - In drivers/power/domain/qcom-rpmhpd.c, the 'ret' variable in rpmhpd_probe() is initialized with 0
>> - Link to v5: https://lore.kernel.org/u-boot/20251027113312.3815169-1-aswinm@qti.qualcomm.com/
>>
>> Changes in v5:
>> - As part of "qcom_rpmhpd" driver removal change did in v4, the rpmh_write() in drivers/power/domain/qcom-rpmhpd.c
>>    should be passed with pd->dev as first argument to align with it.
>> - Added (ulong) casting in rpmhpd_match_table to address the warning.
>>
>> Changes in v4:
>> - Added all soc entries in power domain linux driver to drivers/power/domain/qcom-rpmhpd.c and
>>    stubbed it
>> - Removed "qcom_rpmhpd" driver & unused members of struct rpmhpd in drivers/power/domain/qcom-rpmhpd.c
>> - Moved the "soc: qcom: cmd-db" change before the "power-domain" change
>> - Link to v3: https://lore.kernel.org/u-boot/20250702180133.1889709-1-aswin.murugan@oss.qualcomm.com/
>>
>> Changes in v3:
>> - Removed OF_LIVE_SA8775P config in arch/arm/mach-snapdragon/Kconfig & configs/qcs9100_defconfig,
>>    since there is no SA8775p specific fixups are done
>> - Link to v2: https://lore.kernel.org/u-boot/20250702171335.1811080-1-aswin.murugan@oss.qualcomm.com/
>>
>> Changes in v2:
>> - Added ARCH_SNAPDRAGON dependency to QCOM_POWER_DOMAIN in drivers/power/domain/Kconfig
>> - In drivers/power/domain/qcom-rpmhpd.c, the un-supported power domains are handled with warning
>> - Power domain fixups have been removed since they are now managed by drivers/power/domain/qcom-rpmhpd.c
>> - Link to v1: https://lore.kernel.org/u-boot/20250626112441.143064-1-aswin.murugan@oss.qualcomm.com/
>> ---
>>
>> Aswin Murugan (5):
>>    soc: qcom: cmd-db: Add cmd_db_read_slave_id() & cmd_db_read_aux_data()
>>      functions
>>    power-domain: Add QCOM RPMH Power Domain Driver Support
>>    power-domain: Add warning when power-domain driver is missing
>>    mach-snapdragon: fixup power-domains
>>    configs: qcom: Add QCOM_POWER_DOMAIN config
>>
>>   arch/arm/mach-snapdragon/of_fixup.c        |  31 ---
>>   configs/qcom_defconfig                     |   1 +
>>   drivers/power/domain/Kconfig               |   8 +
>>   drivers/power/domain/Makefile              |   1 +
>>   drivers/power/domain/power-domain-uclass.c |   7 +
>>   drivers/power/domain/qcom-rpmhpd.c         | 278 +++++++++++++++++++++
>>   drivers/soc/qcom/cmd-db.c                  |  45 ++++
>>   include/soc/qcom/cmd-db.h                  |   2 +
>>   8 files changed, 342 insertions(+), 31 deletions(-)
>>   create mode 100644 drivers/power/domain/qcom-rpmhpd.c
>>