[PATCH v3 11/11] efi_loader: add ACPI table dump EFI app

[Simon Glass]

Hi Heinrich,

On Wed, 1 Jul 2026 at 14:28, Heinrich Schuchardt
<heinrich.schuchardt at canonical.com> wrote:
>
> On 7/1/26 14:01, Simon Glass wrote:
> > Hi Heinrich,
> >
> > On 2026-06-28T08:27:58, Heinrich Schuchardt
> > <heinrich.schuchardt at canonical.com> wrote:
> >> efi_loader: add ACPI table dump EFI app
> >>
> >> Provide an EFI binary that can dump all ACPI tables to files
> >> <table_name>.dat. These can then be further analyzed by decompiling
> >> with iasl.
> >>
> >> The DSDT and FACS tables are identified via FADT.
> >>
> >> The following commands are provided:
> >>
> >> * check - parse ACPI table list\r\n", do_check
> >> * write - save one file per ACPI table\r\n", do_write
> >>
> >> The file names are constructed from:
> >>
> >> * 4 character ACPI table name
> >> * number if there are multiple ACPI tables of the same type
> >> * '.dat' extension
> >>
> >> This matches the output of the Linux acpidump -b command.
> >> [...]
> >>
> >> lib/efi_loader/Makefile   |   3 +-
> >>   lib/efi_loader/acpidump.c | 566 ++++++++++++++++++++++++++++++++++++++++++++++
> >>   2 files changed, 568 insertions(+), 1 deletion(-)
> >
> > Did you see my comments on v2?
> >
> > Regards,
> > Simon
>
> I thought the v3 change covered them all.
>
> What did I miss?

There was one about the .dat suffix when name_size is too small. Also
allocating a buffer when it seems it is not needed.

Its fine if you don't think they are worth doing...just checking.

BTW there is also some \r\n" in the commit message in this version.

Anyway, whichever you do:

Reviewed-by: Simon Glass <sjg at chromium.org>

Regards,
Simon