[PATCH v2 07/16] LoongArch: lib: General routines

Jiaxun Yang jiaxun.yang at flygoat.com
Thu Jul 2 11:24:28 CEST 2026



On Wed, 1 Jul 2026, at 6:49 PM, Tom Rini wrote:
> On Wed, Jul 01, 2026 at 11:17:59AM +0000, Yao Zi wrote:
>
>> From: Jiaxun Yang <jiaxun.yang at flygoat.com>
>> 
>> Add some common library routines for the architecture.
>> 
>> Signed-off-by: Jiaxun Yang <jiaxun.yang at flygoat.com>
>> Signed-off-by: Yao Zi <me at ziyao.cc>
> [snip]
>> +#define CACHE_MAX_LEVEL		3
>> +#define CACHE_MAX_INDEX		6
>> +#define CACHE_OP		GENMASK(4, 3)
>> +#define  CACHE_INDEX_INVWB	0x1
>> +#define  CACHE_HIT_INVWB	0x2
>> +#define CACHE_INDEX		GENMASK(2, 0)
>
> I was expecting checkpatch.pl to catch the double space here, but it
> didn't. It did warn about a few other things in macros, which should be
> checked out at least. And that comment applies for the whole series,
> along with a manual check for other spacing issues, thanks!

Those style issues are mostly copied over Linux kernel counterparts, should
we leave them as is to ease kernel rebasing effort, or fix them for consistency
with rest of the U-Boot?

Thanks

>
> -- 
> Tom
>
> Attachments:
> * signature.asc

-- 
- Jiaxun


More information about the U-Boot mailing list