[PATCH] cmd: kconfig: i2c: add DM_I2C dependency

[Julien Stephan]

Le jeu. 2 juil. 2026 à 06:30, Heiko Schocher <hs at nabladev.com> a écrit :
>
> Hello Tom,
>
> On 01.07.26 18:18, Tom Rini wrote:
> > On Wed, Jul 01, 2026 at 05:55:14PM +0200, Julien Stephan wrote:
> >
> >> CMD_I2C depends on the DM I2C API but currently does not enforce
> >> DM_I2C in Kconfig.
> >>
> >> This can lead to link errors caused by unresolved i2c_* symbols when
> >> CMD_I2C is enabled without DM_I2C.
> >>
> >> Add the missing dependency to prevent unsupported configurations.
> >>
> >> Signed-off-by: Julien Stephan <jstephan at baylibre.com>
> >> ---
> >>   cmd/Kconfig | 1 +
> >>   1 file changed, 1 insertion(+)
> >>
> >> diff --git a/cmd/Kconfig b/cmd/Kconfig
> >> index 032e55e8127..636891ed493 100644
> >> --- a/cmd/Kconfig
> >> +++ b/cmd/Kconfig
> >> @@ -1392,6 +1392,7 @@ config CMD_IOTRACE
> >>
> >>   config CMD_I2C
> >>      bool "i2c"
> >> +    depends on DM_I2C
> >>      help
> >>        I2C support.
> >>
> >
> > This removes the command from the handful of still legacy I2C boards:
> > $ ./tools/qconfig.py -f CMD_I2C ~DM_I2C
> > 15 matches
> > MPC837XERDB cl-som-imx7 d2net_v2 db-88f6720 db-88f6820-gp inetspace_v2 ls2080aqds_nand ls2080aqds_qspi ls2080ardb_nand net2big_v2 netspace_lite_v2 netspace_max_v2 netspace_mini_v2 netspace_v2 work_92105
> >
> > So the depends on needs an "|| ..." in there, for the I2C but not DM_I2C
> > case. Thanks.

Hi Tom,

Thank you for catching that. I was wondering if I should handle the
legacy devices..

./tools/qconfig.py -f CMD_I2C SYS_I2C_MV ~DM_I2C ~SYS_I2C_LEGACY
0 matches

So I guess  depends on DM_I2C || SYS_I2C_LEGACY should work?

Thanks
Julien
>
> Thanks for checking this!
>
> bye,
> Heiko
> --
> Nabla Software Engineering
> HRB 40522 Augsburg
> Phone: +49 821 45592596
> E-Mail: office at nabladev.com
> Geschäftsführer : Stefano Babic