[PATCH 1/6] Revert "qcom_defconfig: enable psci based sysreset"
Quentin Schulz
foss+uboot at 0leil.net
Thu Jul 2 20:27:31 CEST 2026
From: Quentin Schulz <quentin.schulz at cherry.de>
This reverts commit 63c806ba0e1236fea500f5d8b5486196d7c20806.
The args support for the sysreset uclass contains a logic bug. The first
sysreset device implementing the request_arg callback will consume the
args, not support the specified arg and thus return -EPROTONOSUPPORT
which will stop the iteration over all sysreset devices.
This is an issue if one has multiple sysreset devices and each with
support for different (valid) args. If a sysreset device implements a
-dummy argument and another -foo and one calls reset -dummy on the
U-Boot CLI, it'll depend on which sysreset device will be attempted
first. If it is the one implementing -foo, it'll return it doesn't
support the argument with -EPROTONOSUPPORT in which case the device
implementing -dummy will never be attempted and instead we'll do a cold
reset which is very likely not what's expected.
Signed-off-by: Quentin Schulz <quentin.schulz at cherry.de>
---
configs/qcom_defconfig | 2 --
1 file changed, 2 deletions(-)
diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig
index d0d54ec5a70b..b0d0f51b1c02 100644
--- a/configs/qcom_defconfig
+++ b/configs/qcom_defconfig
@@ -133,8 +133,6 @@ CONFIG_QCOM_RPMH=y
CONFIG_SPMI_MSM=y
CONFIG_SYSINFO=y
CONFIG_SYSINFO_SMBIOS=y
-CONFIG_SYSRESET_CMD_RESET_ARGS=y
-CONFIG_SYSRESET_QCOM_PSCI=y
CONFIG_SYSRESET_QCOM_PSHOLD=y
CONFIG_USB=y
CONFIG_USB_XHCI_HCD=y
--
2.55.0
More information about the U-Boot
mailing list