[PATCH v2 01/10] cmd: aes: fix DM operation handling
James Hilliard
james.hilliard1 at gmail.com
Fri Jul 3 03:49:46 CEST 2026
The DM AES command path takes operation-specific arguments after the
common arguments. argv[1] holds the mode, "ecb" or "cbc", while argv[2]
holds the requested operation, "enc" or "dec".
The DM path checked argv[1] for the operation, so the ecb and cbc
commands always returned CMD_RET_USAGE before running. Parse argv[2]
instead.
Fixes: b01444aa14cf ("cmd: aes: Add support for DM AES drivers")
Signed-off-by: James Hilliard <james.hilliard1 at gmail.com>
---
Changes v1 -> v2:
- Limit the patch to the argv parsing fix (suggested by Simon Glass)
- State that the commands always returned usage (suggested by Simon Glass)
- Add a Fixes tag (suggested by Simon Glass)
---
cmd/aes.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/cmd/aes.c b/cmd/aes.c
index 3fd83013ffe..edcd87cf11b 100644
--- a/cmd/aes.c
+++ b/cmd/aes.c
@@ -175,9 +175,9 @@ int cmd_aes_ecb(int argc, char *const argv[], u32 key_len)
if (ret)
return ret;
- if (!strncmp(argv[1], "enc", 3))
+ if (!strncmp(argv[2], "enc", 3))
enc = 1;
- else if (!strncmp(argv[1], "dec", 3))
+ else if (!strncmp(argv[2], "dec", 3))
enc = 0;
else
return CMD_RET_USAGE;
@@ -223,9 +223,9 @@ int cmd_aes_cbc(int argc, char *const argv[], u32 key_len)
if (ret)
return ret;
- if (!strncmp(argv[1], "enc", 3))
+ if (!strncmp(argv[2], "enc", 3))
enc = 1;
- else if (!strncmp(argv[1], "dec", 3))
+ else if (!strncmp(argv[2], "dec", 3))
enc = 0;
else
return CMD_RET_USAGE;
--
2.53.0
More information about the U-Boot
mailing list