[PATCH v2 2/2] usb: gadget: Add Renesas RZ/N1 USBF controller support

[Marek Vasut]

On 7/2/26 10:11 AM, Romain Gantois wrote:
> From: Herve Codina <herve.codina at bootlin.com>
> 
> Add support for the Renesas USBF controller. This is an USB2.0 UDC
> controller available in the RZ/N1 SoC.
> 
> This driver was originally written by Hervé Codina for the Linux kernel.
> Suspend/resume features have been removed in this U-Boot port.
> 
> Linux revision this was ported from:
> 
> 74851fbb6d64 usb: gadget: renesas_usbf: Handle devm_pm_runtime_...

Please use the canonical short format:

74851fbb6d64 ("usb: gadget: renesas_usbf: Handle 
devm_pm_runtime_enable() errors")

But diff between the Linux kernel driver file and this driver shows 
changes in indent and removed spin lock invocations, can you retain 
those and possibly stub them with noop functions instead ? At least the 
spinlocks and indent should be doable.

[...]

> +static const struct udevice_id usbf_match[] = {
> +	{ .compatible = "renesas,rzn1-usbf" },
> +	{} /* sentinel */
> +};
> +
> +U_BOOT_DRIVER(usbf_renesas_udc) = {
> +	.name	= "usbf_renesas",
> +	.id = UCLASS_USB_GADGET_GENERIC,
> +	.of_match = usbf_match,
> +	.ops = &usbf_gadget_generic_ops,
> +	.probe = usbf_probe,
> +	.remove = usbf_remove,
> +	.priv_auto	= sizeof(struct usbf_udc),
> +};

Nitpick, please use either space or tab before = , but use only one and 
use it consistently.

Thank you !