[PATCH v2 1/7] pmbus: add PMBus 1.x framework, CLI, and binding

Vincent Jardin vjardin at free.fr
Mon Jul 6 12:27:34 CEST 2026


Hi Peng,

Below some feedbacks on you reviews. More will be provided into
a v3.

> >+			if (pmbus_read_string(chip, reg, s, sizeof(s),
> >+					      act->info ? false : false) >= 0)
> 
> Should be true : false or false: true?

hmm ;) it is a leftover, I'll clean it.

> >+	ret = dm_i2c_read(dev, cmd, raw, len + 1);
> 
> When len is 16, len + 1 bytes are read, so corrupt u8 raw[].

right, I'll improve it for v3, thanks for detecting it.

best regards,
  Vincent


More information about the U-Boot mailing list