[PATCH 19/24] clk: mediatek: drop parent udevice field
David Lechner
dlechner at baylibre.com
Wed Jul 8 18:11:44 CEST 2026
On 7/8/26 9:59 AM, Julien Stephan wrote:
> Le mar. 7 juil. 2026 à 17:10, David Lechner <dlechner at baylibre.com> a écrit :
>>
>> Remove the parent field from the mediatek clock private data structures.
>> This was no longer used other than debug prints.
>>
>
> Hi David,
>
> Looks like this commit is breaking mmc on me Genio 700 board.
>
> Card did not respond to voltage select! : -5
>
> And then it fails to boot.
> clk dump output is equivalent to what I used to have on my Genio 700
> (without the parent debug print)
This is unexpected since in theory this commit should just be removing
dead code. I'll try to see if I can reproduce that.
>
> One more minor comment inline below
>
> Cheers
> Julien
>
...
>>
>> -static int mtk_common_clk_init_drv(struct udevice *dev,
>> - const struct mtk_clk_tree *tree,
>> - const struct driver *drv)
>> +int mtk_common_clk_init(struct udevice *dev, const struct mtk_clk_tree *tree)
>> {
>> struct mtk_clk_priv *priv = dev_get_priv(dev);
>> - struct udevice *parent;
>> int ret;
>
> ret is now unused
>
Strange... buildman caught this in other cases where I made the same
mistake I wonder why not this one.
More information about the U-Boot
mailing list