[PATCH v6 07/11] mach-snapdragon: Add initial support for IPQ5210 SPL

[Varadarajan Narayanan]

[ . . . ]
> > +#define QCOM_SPL_IS_DLOAD_BIT_SET	((readl(QCOM_SPL_TCSR_REG_ADDR) & \
> > +					QCOM_SPL_DLOAD_MASK) >> \
> > +					QCOM_SPL_DLOAD_SHFT)
>
> Unused?

It is used in spl_board_prepare_for_boot() in the next patch. Will move it.

> > +#define QCOM_SPL_FIT_IMG_PARTITION	"0:BOOTLDR"
> > +
> > +#define MAGIC_KEY			"QCLIB_CB"
> > +#define MAX_ENTRIES			0xF
> > +#define IF_TABLE_VERSION		0x1
> > +#define QCCONFIG			"qc_config"
> > +#define QCSDI				"qcsdi"
>
> Please document this API (as in, under doc/) maybe show examples of what
> this magic "interface_table" might contain, etc.
>
> I'm quite wary around this, we want to keep working to reduce the board
> specific hacks and code, providing more info about what this does, how it
> works, it's all going to help justify these patches.
>
> It would also help to split this out, have a patch with the FIT parsing
> stuff, then add the qclib API, then add the board code.

Ok.

Thanks
Varada

[ . . . ]