[PATCH 2/2] cmd: ufetch: only show comma separator if there was a previous feature

Simon Glass sjg at chromium.org
Mon May 4 14:06:02 CEST 2026


Hi Quentin,

On 2026-04-28T10:56:03, Quentin Schulz <foss+uboot at 0leil.net> wrote:
> cmd: ufetch: only show comma separator if there was a previous feature
>
> Currently, if NET is disabled, the next feature to be printed will start
> with a comma and a space which is not pretty. Add the comma and
> whitespace only when a previous feature has already been shown.
>
> Signed-off-by: Quentin Schulz <quentin.schulz at cherry.de>
>
> cmd/ufetch.c | 29 ++++++++++++++++++++---------
>  1 file changed, 20 insertions(+), 9 deletions(-)

> diff --git a/cmd/ufetch.c b/cmd/ufetch.c
> @@ -157,26 +157,37 @@ static int do_ufetch(struct cmd_tbl *cmdtp, int flag, int argc,
> +                     if (IS_ENABLED(CONFIG_CMD_CAT)) {
> +                             printf(":%scat :3", sep ? ", " : "");
> +                             sep = true;
> +                     }

Do you want the ':' before the '%s' ?

Reviewed-by: Simon Glass <sjg at chromium.org>

Regards,
Simon


More information about the U-Boot mailing list