[PATCH] gpio: Correct dependencies for MCP230xx

Quentin Schulz quentin.schulz at cherry.de
Thu May 7 18:53:22 CEST 2026


On 5/7/26 6:51 PM, Quentin Schulz wrote:
> Hi Charles,
> 
> On 5/5/26 3:34 PM, Charles Perry wrote:
>> [You don't often get email from charles.perry at microchip.com. Learn why 
>> this is important at https://aka.ms/LearnAboutSenderIdentification ]
>>
>> This driver depends on DM_I2C and DM_SPI, add it.
>>
> 
> Wondering if we shouldn't split that driver in two symbols, one for I2C 
> and one for SPI such that you don't need both if you only have a device 
> over I2C/SPI.
> 

Just want to clarify that this is "it would be nice if we could do X", 
this is not a requirement though. The immediate issue is you cannot 
build this driver without DM_I2C or DM_SPI not set, so this patch is 
fine with the small change requested below.

>> Signed-off-by: Charles Perry <charles.perry at microchip.com>
>> ---
>>   drivers/gpio/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
>> index 37cb672697c0..3ced3fb32f24 100644
>> --- a/drivers/gpio/Kconfig
>> +++ b/drivers/gpio/Kconfig
>> @@ -309,7 +309,7 @@ config MAX77663_GPIO
>>
>>   config MCP230XX_GPIO
>>          bool "MCP230XX GPIO driver"
>> -       depends on DM
>> +       depends on DM && DM_I2C && DM_SPI
>>          help
>>            Support for Microchip's MCP230XX I2C connected GPIO devices.
> 
> Can you update the help text to say this supports SPI-connected GPIO 
> devices as well (the SPI-connected devices are listed below, outside the 
> git context but if someone doesn't know better, it'll be difficult to 
> figure this out)?
> 
> With that,
> 
> Reviewed-by: Quentin Schulz <quentin.schulz at cherry.de>
> 
> Thanks!
> Quentin



More information about the U-Boot mailing list