[PATCH v2 0/5] NBX10G: Marvell Armada 8040 Nodebox 10G board support

Stefan Roese stefan.roese at mailbox.org
Fri May 8 13:08:15 CEST 2026


On 4/21/26 11:04, Vincent Jardin wrote:
> This v2 addresses Stefan Roese's review feedback on v1:
>    https://lists.denx.de/pipermail/u-boot/2026-March/613625.html
> 
> Changes since v1:
>   - Patch 1 (cpuinfo/SAR): added Reviewed-by Stefan
>   - Patch 2 (board support):
>       * dropped board_init() bi_boot_params assignment
>         (ARM64 uses FDT, ATAGS are !ARM64-only)
>       * dropped empty board_early_init_f()
>       * removed unused includes / DECLARE_GLOBAL_DATA_PTR
>       * added note on U-Boot vs Linux comphy DT bindings
>       * MAINTAINERS: armada-8040-nbx* wildcard covers the u-boot dtsi;
>         removed duplicate NBX BOARD entry from
>         board/Marvell/mvebu_armada-8k/MAINTAINERS
>       * added Reviewed-by Stefan
>   - Patch 3 (emmcboot): moved from cmd/mvebu/ to board/freebox/nbx10g/,
>       renamed Kconfig CMD_MVEBU_EMMCBOOT -> CMD_NBX_EMMCBOOT and
>       MVEBU_MMC_PART_* -> NBX_MMC_PART_*, replaced all `return -1`
>       with `return -EINVAL`, commit message now explains legacy format
>   - Patch 4 (fbxserial): moved from cmd/mvebu/ to board/freebox/nbx10g/,
>       replaced all `return -1` with proper errno codes
>       (-EINVAL for data validation, -ENODEV for missing MMC,
>        -EIO for MMC I/O failures)
>   - Patch 5 (U-Boot dtsi): added Reviewed-by Stefan

Thanks. Next time, please include this revision history into the
patches. This makes the review a bit easier. Please see here:

https://docs.u-boot.org/en/stable/develop/sending_patches.html#sending-updated-patch-versions

Thanks,
Stefan

> Build tested on Nodebox 10G (ATF v2.14 + U-Boot 2026.04 + Linux 6.19),
> all functionality verified on hardware.
> 
> Vincent Jardin (5):
>    arm: mach-mvebu: armada8k: cpuinfo and SAR
>    board: freebox: add Nodebox 10G board support
>    board: freebox: nbx10g: add emmcboot for dual-bank eMMC boot
>    board: freebox: nbx10g: add device serial and MAC address
>      initialization
>    arm: dts: armada-8040-nbx: add U-Boot dtsi for conditional OP-TEE
> 
>   arch/arm/dts/Makefile                    |   1 +
>   arch/arm/dts/armada-8040-nbx-u-boot.dtsi |  15 +
>   arch/arm/dts/armada-8040-nbx.dts         | 259 ++++++++++++++++
>   arch/arm/mach-mvebu/Kconfig              |   9 +
>   arch/arm/mach-mvebu/armada8k/Makefile    |   2 +-
>   arch/arm/mach-mvebu/armada8k/cpu.c       |  12 +
>   arch/arm/mach-mvebu/armada8k/soc_info.c  | 194 ++++++++++++
>   arch/arm/mach-mvebu/armada8k/soc_info.h  |  14 +
>   board/freebox/nbx10g/Kconfig             |  94 ++++++
>   board/freebox/nbx10g/MAINTAINERS         |   6 +
>   board/freebox/nbx10g/Makefile            |   5 +
>   board/freebox/nbx10g/board.c             |  53 ++++
>   board/freebox/nbx10g/nbx_emmcboot.c      | 357 +++++++++++++++++++++++
>   board/freebox/nbx10g/nbx_fbxserial.c     | 286 ++++++++++++++++++
>   board/freebox/nbx10g/nbx_fbxserial.h     | 156 ++++++++++
>   board/freebox/nbx10g/nbx_imagetag.h      |  78 +++++
>   board/freebox/nbx10g/nbx_nrboot.h        |  34 +++
>   configs/mvebu_nbx_88f8040_defconfig      |  75 +++++
>   include/configs/nbx10g.h                 |  29 ++
>   19 files changed, 1678 insertions(+), 1 deletion(-)
>   create mode 100644 arch/arm/dts/armada-8040-nbx-u-boot.dtsi
>   create mode 100644 arch/arm/dts/armada-8040-nbx.dts
>   create mode 100644 arch/arm/mach-mvebu/armada8k/soc_info.c
>   create mode 100644 arch/arm/mach-mvebu/armada8k/soc_info.h
>   create mode 100644 board/freebox/nbx10g/Kconfig
>   create mode 100644 board/freebox/nbx10g/MAINTAINERS
>   create mode 100644 board/freebox/nbx10g/Makefile
>   create mode 100644 board/freebox/nbx10g/board.c
>   create mode 100644 board/freebox/nbx10g/nbx_emmcboot.c
>   create mode 100644 board/freebox/nbx10g/nbx_fbxserial.c
>   create mode 100644 board/freebox/nbx10g/nbx_fbxserial.h
>   create mode 100644 board/freebox/nbx10g/nbx_imagetag.h
>   create mode 100644 board/freebox/nbx10g/nbx_nrboot.h
>   create mode 100644 configs/mvebu_nbx_88f8040_defconfig
>   create mode 100644 include/configs/nbx10g.h
> 



More information about the U-Boot mailing list