[PATCH v2 0/4] binman: Tidy up some missing bintool docs
Quentin Schulz
quentin.schulz at cherry.de
Fri May 8 14:01:32 CEST 2026
Hi Simon,
On 5/5/26 8:12 PM, Simon Glass wrote:
> Some of the bintools are missing documentation. This series adds the
> missing pieces to bring things up to scratch.
>
> Changes in v2:
> - Add patch to route PKCS#11 test fixtures through the bintools
> - New patch in v2 (per Quentin's review): replace tools.run() of
> softhsm2-util, pkcs11-tool and p11-kit in ftest.py with the
> Bintool.run_cmd() wrapper that already exists
> - Reword the docstring per Quentin's review: binman uses this bintool
> only as an availability check, not for runtime PKCS#11 operations
>
> Simon Glass (4):
> binman: Flesh out the p11-kit bintool docstring
> binman: Flesh out the pkcs11-tool bintool docstring
> binman: Flesh out the softhsm2-util bintool docstring
> binman: Use bintool wrappers for PKCS#11 tools in tests
>
> tools/binman/btool/p11_kit.py | 11 ++++++-
> tools/binman/btool/pkcs11_tool.py | 11 ++++++-
> tools/binman/btool/softhsm2_util.py | 12 +++++++-
> tools/binman/ftest.py | 46 ++++++++++++++---------------
> 4 files changed, 54 insertions(+), 26 deletions(-)
>
Technically the docstring in patch 1 to 3 is incorrect now that we have
patch 4 and we use the bintool to call commands on the wrapped binaries.
It's a detail and I don't have anything else to suggest for rephrasing.
Reviewed-by: Quentin Schulz <quentin.schulz at cherry.de>
Thanks!
Quentin
More information about the U-Boot
mailing list