[PATCH 2/2] gpio: qcom: Staticize and constify driver ops

Casey Connolly casey.connolly at linaro.org
Mon May 11 14:26:58 CEST 2026



On 08/05/2026 00:05, Marek Vasut wrote:
> Set the ops structure as static const. The structure is not accessible
> from outside of this driver and is not going to be modified at runtime.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>

Reviewed-by: Casey Connolly <casey.connolly at linaro.org>

> ---
> Cc: Casey Connolly <casey.connolly at linaro.org>
> Cc: David Wronek <david.wronek at mainlining.org>
> Cc: Jens Reidel <adrian at mainlining.org>
> Cc: Luca Weiss <luca.weiss at fairphone.com>
> Cc: Neil Armstrong <neil.armstrong at linaro.org>
> Cc: Rui Miguel Silva <rui.silva at linaro.org>
> Cc: Sumit Garg <sumit.garg at kernel.org>
> Cc: Tom Rini <trini at konsulko.com>
> Cc: u-boot-qcom at groups.io
> Cc: u-boot at lists.denx.de
> ---
>  drivers/gpio/qcom_spmi_gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/qcom_spmi_gpio.c b/drivers/gpio/qcom_spmi_gpio.c
> index 77a69140213..ae75a4e151d 100644
> --- a/drivers/gpio/qcom_spmi_gpio.c
> +++ b/drivers/gpio/qcom_spmi_gpio.c
> @@ -1020,7 +1020,7 @@ static int qcom_spmi_pmic_pinctrl_pinmux_set_mux(struct udevice *dev, unsigned i
>  	return spmi_pmic_gpio_write(plat, pad, PMIC_GPIO_REG_EN_CTL, val);
>  }
>  
> -struct pinctrl_ops qcom_spmi_pmic_pinctrl_ops = {
> +static const struct pinctrl_ops qcom_spmi_pmic_pinctrl_ops = {
>  	.get_pins_count = qcom_spmi_pmic_pinctrl_get_pins_count,
>  	.get_pin_name = qcom_spmi_pmic_pinctrl_get_pin_name,
>  	.set_state = pinctrl_generic_set_state,

-- 
// Casey (she/her)



More information about the U-Boot mailing list