[PATCH v2 3/7] mtd: spi-nor-ids: Add support for GigaDevice GD25Q256

[Weijie Gao]

On Tue, 2026-05-12 at 06:16 +0000, Takahiro.Kuwano at infineon.com wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Hi,
> 
> > This flash is tested on MediaTek's filogic platform.
> > 
> > The datasheet can be found here:
> > 
https://urldefense.com/v3/__https://download.gigadevice.com/Datasheet/DS-00526-GD25Q256E-Rev1.3.pdf__;!!CTRNKA9wMg0ARbw!ndOq50YXbkGmB3qYwwC_omlvMBrrpmnEYWM7HgPAAAr8lFPMtkm7ZnS3buDbxXZZ_N35sCX5t3lWH9rSvvUY69OHWTYcwkw$
> 
> Please add a quick introduction/description about the device in
> commit
> message and use Link: tag for datasheet reference.
> 
> > 
> > Signed-off-by: Weijie Gao <weijie.gao at mediatek.com>
> > ---
> > v2: updated commit message
> > ---
> >  drivers/mtd/spi/spi-nor-ids.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-
> > nor-ids.c
> > index fcc546fb5ae..8b74fbd4946 100644
> > --- a/drivers/mtd/spi/spi-nor-ids.c
> > +++ b/drivers/mtd/spi/spi-nor-ids.c
> > @@ -147,6 +147,11 @@ const struct flash_info spi_nor_ids[] = {
> >                         SECT_4K | SPI_NOR_DUAL_READ |
> > SPI_NOR_QUAD_READ |
> >                         SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> >         },
> > +       {
> > +               INFO("gd25q256", 0xc84019, 0, 64 * 1024, 512,
> > +                       SECT_4K | SPI_NOR_DUAL_READ |
> > SPI_NOR_QUAD_READ |
> > +                       SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> 
> Did you test locking feature?
> Per datasheet, this device has 4-bit BPs and TB at SR BIT(6), while
> current
> u-boot supports 3-bit BPs and TB at SR BIT(5) only.

This is a copy-paste mistake. I'll remove these two flags.

> 
> > +       },
> >         /* adding these 3V QSPI flash parts */
> >         {INFO("gd25b256", 0xc84019, 0, 64 * 1024, 512,  SECT_4K |
> >         SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK |
> > SPI_NOR_4B_OPCODES)  },
> > --
> > 2.45.2
> 
> Thanks,
> Takahiro
>