[PATCH] pci: pcie_dw_qcom: Staticize and constify driver ops

Neil Armstrong neil.armstrong at linaro.org
Tue May 12 14:46:55 CEST 2026


On 5/8/26 14:21, Marek Vasut wrote:
> Set the ops structure as static const. The structure is not accessible
> from outside of this driver and is not going to be modified at runtime.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>
> ---
> Cc: Casey Connolly <casey.connolly at linaro.org>
> Cc: Neil Armstrong <neil.armstrong at linaro.org>
> Cc: Patrice Chotard <patrice.chotard at foss.st.com>
> Cc: Peng Fan <peng.fan at nxp.com>
> Cc: Sumit Garg <sumit.garg at kernel.org>
> Cc: Tom Rini <trini at konsulko.com>
> Cc: Yao Zi <me at ziyao.cc>
> Cc: u-boot-qcom at groups.io
> Cc: u-boot at lists.denx.de
> ---
>   drivers/pci/pcie_dw_qcom.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/pcie_dw_qcom.c b/drivers/pci/pcie_dw_qcom.c
> index 10c45aaba20..ce6b4d97d1d 100644
> --- a/drivers/pci/pcie_dw_qcom.c
> +++ b/drivers/pci/pcie_dw_qcom.c
> @@ -22,7 +22,7 @@
>   
>   struct qcom_pcie;
>   
> -struct qcom_pcie_ops {
> +static const struct qcom_pcie_ops {
>   	int (*config_sid)(struct qcom_pcie *priv);
>   };
>   

Reviewed-by: Neil Armstrong <neil.armstrong at linaro.org>

Thanks,
Neil


More information about the U-Boot mailing list