[PATCH v2 2/3] configs: stm32mp13: activate watchdog

[Patrick DELAUNAY]

Hi,

On 5/20/26 09:05, Yann Gautier wrote:
> On 5/19/26 18:58, Marek Vasut wrote:
>> On 5/19/26 6:31 PM, Yann Gautier wrote:
>>> No watchdog was enabled for STM32MP13 platform. Add the required 
>>> flags to
>>> support it. As done for STM32MP15 (in SCMI config) and STM32MP2x, we 
>>> use
>>> the Arm SMC watchdog. The required nodes were already present in Linux
>>> imported DT files (stm32mp13.dtsi & stm32mp135f-dk.dts).
>>>
>>> Signed-off-by: Patrick Delaunay <patrick.delaunay at foss.st.com>
>>> Signed-off-by: Yann Gautier <yann.gautier at foss.st.com>
>>>
>>> ---
>>>
>>> Changes in v2:
>>> - update commit message
>>>
>>>   configs/stm32mp13_defconfig | 3 +++
>>>   1 file changed, 3 insertions(+)
>>>
>>> diff --git a/configs/stm32mp13_defconfig b/configs/stm32mp13_defconfig
>>> index 620a6da2efe3..cc41585097c7 100644
>>> --- a/configs/stm32mp13_defconfig
>>> +++ b/configs/stm32mp13_defconfig
>>> @@ -113,4 +113,7 @@ CONFIG_USB_GADGET_MANUFACTURER="STMicroelectronics"
>>>   CONFIG_USB_GADGET_VENDOR_NUM=0x0483
>>>   CONFIG_USB_GADGET_PRODUCT_NUM=0x5720
>>>   CONFIG_USB_GADGET_DWC2_OTG=y
>>> +CONFIG_WDT=y
>>> +CONFIG_WDT_STM32MP=y
>> Why is CONFIG_WDT_STM32MP enabled here , is this the ARM SMC watchdog 
>> driver ?
> This is aligned with stm32mp15 config, and no, this one is the STM32 
> IWDG driver.
> I'll check that with Patrick (who originally wrote the patch), as it 
> seems that this flag could be removed.
>

I agree with Marek.

Today CONFIG_WDT_STM32MP is not really needed as only arm_wdt is 
activated in STM32MP13 device tree for ST boards

with secure watchdog managed in OP-TEE = iwdg1.

in fact, I activated this driver in U-Boot for STM32MP15 alignment

and because the watchdog topology wasn't not yet clear for STM32 boards;

it was perhaps planed to manage 2 watchdogs:

  * iwdg1 => secure watchdog managed by OP-TEE
  * iwdg2 => non secure watchdog managed by U-Boot/Linux


But finally we activate only one watchdog in secure world, exported with 
ARM SMC to non-secure world.

So this flag can be dropped (to avoid to have a unused driver) in all 
STM32MP defconfig files

except for "stm32mp15_basic_defconfig" (i.e. when OP-TEE is not used for 
ST boards).


> Best regards,
> Yann


Regards

Patrick